Skip to content

Avoid removing reference to artwork for tracks without the album tag #1607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Zapdatt wants to merge 5 commits into
base: public/9.2
Choose a base branch
from
+3 −2
Open

Avoid removing reference to artwork for tracks without the album tag #1607

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
ce0cd23
add user check whether or not to remove the artwork.
Zapdatt Jul 7, 2026
92efd74
Add disableArtworkCleanup to prefs lista
Zapdatt Jul 7, 2026
01799ff
Add artwork cleanup setting to performance page
Zapdatt Jul 7, 2026
4d7a624
Add artwork preservation settings strings in EN and SV
Zapdatt Jul 7, 2026
4606027
removed preference, now automatically only update when it has disappe…
Zapdatt Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions Slim/Music/Artwork.pm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,8 +334,9 @@ sub updateStandaloneArtwork {

Slim::Utils::Scheduler::unpause() if !main::SCANNER;
}
# cover art has disappeared
elsif ( !$newCoverId ) {

# Only if cover art has disappeared; set reference default
elsif (!$newCoverId && $coverid && $albumid) {

@michaelherger michaelherger Jul 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm currently reviewing another PR which is dealing with this, too, but somewhat different. Maybe you want to chime in there?

https://github.com/LMS-Community/slimserver/pull/1536/changes#diff-d3ed441703979db9e306f111bf1baa60b997d79073561981f017047e3d20e696L339

$sth_update_albums->execute( undef, $albumid );
$sth_update_tracks->execute( 0, undef, $albumid );

Expand Down