GitHub Issue 929: MVTCs not used in lookup search - #7899
Open
XingY wants to merge 3 commits into
Open
Conversation
labkey-matthewb
approved these changes
Jul 31, 2026
labkey-matthewb
left a comment
labkey-matthewb
left a comment
Contributor
There was a problem hiding this comment.
~q has always been scary performance-wise, but that's regardless of this improvement. Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
The gridbar search Q filter currently doesn't support MVTC fields. Even worse, when a MVTC field is present on a grid, the gridbar search is not usable for any fields. This PR adds support for Q filtering on MVTC fields, by applying ILIKE op on each part (delimited by comma) of the provided search string against each element in array.
This PR also wires up document indexing for samples, dataclass data and lists. dataset and assay results currently aren't wired up to index custom fields.
Related Pull Requests
Changes
SqlDialect.array_element_liketo allow ILIKE filter on array