Repository navigation
Add community-health files + Copilot code-review skill - #54
Conversation
…uting Guide, CODEOWNERS, PR template, Copilot instructions Aligns this repo with Plugin.Bluetooth's standard for OSS project hygiene.
There was a problem hiding this comment.
🟡 Changes recommended
.github/copilot-instructions.md lists dependency versions that don’t match Directory.Packages.props, which can mislead contributors.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds standard community-health and contribution guidance files to Plugin.BaseTypeExtensions, aligning the repository’s OSS hygiene (security reporting, contribution expectations, ownership, and PR authoring guidance) with the broader Plugin.* ecosystem.
Changes:
- Added SECURITY, contributing guidelines, and a Contributor Covenant Code of Conduct.
- Added GitHub repo governance/support files: CODEOWNERS and a pull request template.
- Added
.github/copilot-instructions.mddescribing repo structure, build commands, and conventions.
File summaries
| File | Description |
|---|---|
SECURITY.md |
Defines private vulnerability reporting via GitHub and a “latest release only” support policy. |
CONTRIBUTING.md |
Documents branching, commit convention, PR expectations, testing, and documentation requirements. |
CODE_OF_CONDUCT.md |
Adds Contributor Covenant 2.1 code of conduct and reporting path. |
.github/pull_request_template.md |
Adds a PR template tailored to this repo’s extension categories and typical change areas. |
.github/copilot-instructions.md |
Adds repo-specific Copilot guidance (structure, build/test commands, conventions). |
.github/CODEOWNERS |
Establishes default review ownership for the repository. |
Review details
Suppressed comments (1)
.github/copilot-instructions.md:107
- Several dev dependency versions listed here don’t match Directory.Packages.props (Microsoft.NET.Test.Sdk, xunit.runner.visualstudio, and Microsoft.CodeAnalysis.NetAnalyzers). Updating these keeps the guidance accurate and reduces confusion when contributors compare to central package management.
- `xunit` (2.9.3), `xunit.runner.visualstudio` (3.1.5), `FluentAssertions` (7.2.2)
- `coverlet.collector` / `coverlet.msbuild` (10.0.1)
- `Microsoft.NET.Test.Sdk` (18.8.1), `JetBrains.Annotations` (2025.2.0)
- `Microsoft.CodeAnalysis.NetAnalyzers` (10.0.302), `Microsoft.SourceLink.GitHub` (10.0.201)
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Signed-off-by: François Raminosona <framinosona@hotmail.fr>
There was a problem hiding this comment.
🔵 Needs a closer look
A couple of added docs contain concrete inaccuracies (CoC enforcement contact method and Copilot-instructions dependency versions) that should be corrected before merge.
Review details
Suppressed comments (3)
Previously missed (2) — in code that hasn't changed since the last review.
.github/copilot-instructions.md:37
- PR description says the repo has 26
*Extensions.csfiles, but the current source tree contains 25 (underPlugin.BaseTypeExtensions/). Consider updating the PR description to avoid confusing reviewers/contributors.
CODE_OF_CONDUCT.md:49 - “Private message on GitHub” isn’t a real reporting channel (GitHub doesn’t provide private DMs), so this guidance is likely to confuse reporters. Consider pointing to a concrete contact method such as email (via the maintainer’s GitHub profile contact info).
.github/copilot-instructions.md:106
- The dependency versions listed here don’t match the repo’s central versions in Directory.Packages.props (e.g., xunit.runner.visualstudio, Microsoft.NET.Test.Sdk, Microsoft.CodeAnalysis.NetAnalyzers). Keeping these aligned avoids sending contributors to the wrong versions when troubleshooting CI/build issues.
- `xunit` (2.9.3), `xunit.runner.visualstudio` (3.1.5), `FluentAssertions` (7.2.2)
- `coverlet.collector` / `coverlet.msbuild` (10.0.1)
- `Microsoft.NET.Test.Sdk` (18.8.1), `JetBrains.Annotations` (2025.2.0)
- `Microsoft.CodeAnalysis.NetAnalyzers` (10.0.302), `Microsoft.SourceLink.GitHub` (10.0.201)
- Files reviewed: 6/6 changed files
- Comments generated: 0 new
- Review effort level: Lite
CODE_OF_CONDUCT.md pointed at GitHub private messages, which don't exist as a feature. copilot-instructions.md had a stale Logging.Abstractions version and was missing StreamExtensions.cs from the project structure and feature list. Also folds in the code-review agent skill (previously a separate PR) so this repo's community-health-files work lands as one PR.
My previous commit wrongly reverted Logging.Abstractions to a stale value read from an outdated local main. Restored 10.0.11 (correct, already matched by the prior Copilot Autofix commit) and fixed three more genuinely stale versions against this branch's actual Directory.Packages.props: xunit.runner.visualstudio (3.1.5 -> 4.0.0), Microsoft.NET.Test.Sdk (18.8.1 -> 18.9.0), Microsoft.CodeAnalysis.NetAnalyzers (10.0.302 -> 10.0.400).
There was a problem hiding this comment.
🔵 Needs a closer look
The new .github/copilot-instructions.md contains multiple dependency versions that don’t match Directory.Packages.props, which is misleading documentation for contributors.
Review details
Suppressed comments (2)
.github/copilot-instructions.md:101
- The dependency version documented here is out of sync with the repo’s central package versions (Directory.Packages.props currently has Microsoft.Extensions.Logging.Abstractions 10.0.11). Keeping these aligned avoids misleading contributors.
### Production
- `Microsoft.Extensions.Logging.Abstractions` (10.0.11)
.github/copilot-instructions.md:106
- Several development dependency versions listed here don’t match Directory.Packages.props (e.g., xunit.runner.visualstudio is 4.0.0, Microsoft.NET.Test.Sdk is 18.9.0, and Microsoft.CodeAnalysis.NetAnalyzers is 10.0.400). Either update these to match or consider removing specific versions to avoid drift.
- `xunit` (2.9.3), `xunit.runner.visualstudio` (4.0.0), `FluentAssertions` (7.2.2)
- `coverlet.collector` / `coverlet.msbuild` (10.0.1)
- `Microsoft.NET.Test.Sdk` (18.9.0), `JetBrains.Annotations` (2025.2.0)
- `Microsoft.CodeAnalysis.NetAnalyzers` (10.0.400), `Microsoft.SourceLink.GitHub` (10.0.201)
- Files reviewed: 7/7 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🟢 Approval recommended
The changes are documentation/config-only, internally consistent, and match the repository’s current structure and dependency/tooling declarations.
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0 new
- Review effort level: Lite
Summary
Brings this repo's community-health files up to the standard already set by
Plugin.Bluetooth:CODE_OF_CONDUCT.md(Contributor Covenant 2.1)SECURITY.md(private vulnerability reporting)CONTRIBUTING.md(adapted for this repo's actual extension-category-per-file structure).github/CODEOWNERS.github/pull_request_template.md(adapted "Affected Areas" to this repo's real categories:String/Numeric/Enum, Collections, Temporal, Reflection/Assembly, Comparison)
.github/copilot-instructions.md— this repo didn't have one yet (unlikePlugin.Bluetoothand
Plugin.ByteArrays); written from the actual source layout (25*Extensions.csfiles),Directory.Packages.props, andglobal.json..github/skills/code-review/SKILL.md— repo-specific checklist for GitHub Copilot code review(folded in from Add code-review agent skill for GitHub Copilot code review #55, closed as a consolidation of the same community-health-files effort).
Why
Part of a pass aligning all the
Plugin.*OSS repos on code of conduct, security policy,licensing, contributing docs, and issue/PR templates — this repo was one of the three missing
almost all of it.
Review fixes applied
Addressed the automated code-review findings on the original commit:
CODE_OF_CONDUCT.md: "private message on GitHub" isn't a real reporting channel — now pointsto the maintainer's GitHub profile contact info instead.
.github/copilot-instructions.md: was missingStreamExtensions.csfrom the project-structuretree and feature list; dependency version table had drifted from
Directory.Packages.props(
xunit.runner.visualstudio,Microsoft.NET.Test.Sdk,Microsoft.CodeAnalysis.NetAnalyzers) —corrected against the branch's actual current versions.
Test plan
Plugin.BluetoothorPlugin.ByteArraysDirectory.Packages.props(notmain)