Repository navigation
Return 501 when AI apply fix lacks optional SDK - #10
Closed
mikemikimike wants to merge 1 commit into
Closed
mikemikimike wants to merge 1 commit into
mikemikimike wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Member
|
Thanks a lot for the PR, @mikemikimike, and for the clear write-up and test! We're working on a larger overhaul of this package right now, and this fix is already part of it: #20 adds one laravel/ai check used by all three AI endpoints (ai-apply, plus ai-suggest and ai-investigate, which had the same crash), so they return 501 instead of fataling. We'll close this one in favour of that, but your report helped shape the fix. Contributions are very welcome, so feel free to open more! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aiApplyFixis used without the optional Laravel AI SDK.Fixes #7
Issue: #7
Testing
php tests/Issue7AiApplyFixTest.phpcomposer validate --no-check-publishgit diff --check