Skip to content

fix(gh-19): skip streamed and binary responses, add sample_rate - #27

Merged
Nejcc merged 1 commit into
mainfrom
fix/gh-19-skip-streams-sampling
Oct 31, 2026
Merged

Nejcc merged 1 commit into
mainfrom
fix/gh-19-skip-streams-sampling

Conversation

@Nejcc

@Nejcc Nejcc commented Oct 31, 2026

Copy link
Copy Markdown
Member

Closes #19

What

  • ProfileRequest returns StreamedResponse (incl. SSE and StreamedJsonResponse) and BinaryFileResponse untouched and stores no profile for them.
  • New sample_rate config (DIGDEEP_SAMPLE_RATE, default 1.0). Below 1.0, only that share of requests is profiled, which cuts DB writes on busy apps.

Checks

  • 2 new tests (stream + download not stored, sample rate 0 vs 1). composer test: 97 passed.
  • lint, analyse and gitleaks clean.

@coderabbitai

coderabbitai Bot commented Oct 31, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Caution

Review failed

The pull request is closed.

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@Nejcc
Nejcc merged commit eab4787 into main Oct 31, 2026
8 checks passed
@Nejcc
Nejcc deleted the fix/gh-19-skip-streams-sampling branch November 2, 2026 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Skip streamed/binary responses and add sampling

1 participant