Skip to content

fix: use module logger in MQTT subscribe instead of root logger #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sacredserengeti wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: use module logger in MQTT subscribe instead of root logger #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions python_snoo/snoo.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -365,7 +365,7 @@ async def subscribe_mqtt(self, device: SnooDevice, function: Callable):
client_id = f"HA_{uuid.uuid4()}"
user_name = "?SDK=iOS&Version=2.40.1"

logging.debug(f"Attempting to connect to wss://{host}:{port}{websocket_path}")
_LOGGER.debug(f"Attempting to connect to wss://{host}:{port}{websocket_path}")

# The default SSL context creation is a blocking I/O operation.
# Run it in a separate thread to avoid blocking the Home Assistant event loop.
Expand All @@ -385,7 +385,7 @@ async def subscribe_mqtt(self, device: SnooDevice, function: Callable):
protocol=aiomqtt.ProtocolVersion.V31,
timeout=10,
) as client:
logging.info(f"✅ Successfully connected to MQTT broker for {device.serialNumber}!")
_LOGGER.info(f"✅ Successfully connected to MQTT broker for {device.serialNumber}!")

# Acquire the lock, add the client to the map, and notify waiting tasks.
async with self._client_cond:
Expand All @@ -394,19 +394,19 @@ async def subscribe_mqtt(self, device: SnooDevice, function: Callable):

topic = f"{device.awsIoT.thingName}/state_machine/activity_state"
await client.subscribe(topic)
logging.info(f"Subscribed to topic: {topic}")
_LOGGER.info(f"Subscribed to topic: {topic}")

async for message in client.messages:
logging.debug(f"Received message on topic '{message.topic}': {message.payload.decode()}")
_LOGGER.debug(f"Received message on topic '{message.topic}': {message.payload.decode()}")
function(SnooData.from_json(message.payload.decode()))

except aiomqtt.MqttError as e:
logging.error(f"MQTT connection for {device.serialNumber} failed: {e}")
_LOGGER.error(f"MQTT connection for {device.serialNumber} failed: {e}")
except Exception as e:
logging.error(f"MQTT connection for {device.serialNumber} failed with an unexpected error: {e}")
_LOGGER.error(f"MQTT connection for {device.serialNumber} failed with an unexpected error: {e}")
finally:
# When the connection is lost, remove the client from the map.
logging.info(f"MQTT connection closed for {device.serialNumber}.")
_LOGGER.info(f"MQTT connection closed for {device.serialNumber}.")
async with self._client_cond:
if device.serialNumber in self._client_map:
del self._client_map[device.serialNumber]