Repository navigation
🏷️ refactor: Export the Dialog Parts Under Canonical Dialog Names - #17459
Merged
Merged
Conversation
berry-13
marked this pull request as ready for review
October 26, 2026 16:10
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
codegraph-librechat
Bot
added
the
🗺️ UI Foundation
Dialog, DialogContent, DialogTitle and the other parts, and DialogTemplate, are now exported beside their OG names as the same components, so new code and the docs can use the plain names while the existing call sites keep working unchanged.
berry-13
force-pushed
the
berry-13/dialog-canonical-names
branch
from
October 26, 2026 16:37
309043b to
d63f4d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
With the legacy
Dialogremoved in #17430,OGDialogis the only dialog@librechat/clientships, but every one of its parts still carries theOGprefix that only existed to tell it apart from the old one. That prefix would also become the public name of the dialog in the component docs.This PR exports the parts under their plain names (
Dialog,DialogTrigger,DialogContent,DialogHeader,DialogFooter,DialogTitle,DialogDescription,DialogClose,DialogPortal, andDialogTemplateforOGDialogTemplate) as the same components theOGnames already export. Nothing is renamed at the 141 existing call sites; they keep working, and can move to the plain names when they are next touched.DialogOverlaywas already exported under its plain name.Type of change
Testing
Tested environments/configuration:
Automated tests:
dialogNames.spec.ts: each canonical name is exported and is the same component as itsOGname.packages/clientsuite (75 suites, 1148 tests) passes;tsc --noEmitfor both projects is clean.Screenshots / recordings
No user-facing change.
Risk / compatibility
Additive. The plain names were free again after #17430; a consumer still importing the removed legacy
Dialogparts now gets theOGDialogones, whose props are a superset for the primitives (both wrap Radix Dialog) and whose template takes every prop the old one did. The legacyDialogButtonis not restored.Checklist