Repository navigation
📐 feat: Give Dropdown the Positioning Props DropdownPopup Takes - #17461
Merged
Merged
Conversation
berry-13
marked this pull request as ready for review
October 26, 2026 16:40
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
…Popup takes Callers sized and layered Dropdown lists through ad hoc sizeClasses, while DropdownPopup takes sameWidth, minWidth (capped to the room the list has) and gutter. Dropdown now takes the same three, and the Settings dropdowns move onto them and drop z-50 classes the dialog layer already overrides.
berry-13
force-pushed
the
berry-13/dropdown-positioning-props
branch
from
October 26, 2026 16:59
ce07bf2 to
2cedee1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
Dropdown(select a value) andDropdownPopup(run an action) already share their surface and item styling, but not their sizing API.DropdownPopuptakessameWidth,minWidth(capped to the room the list has) andgutter;Dropdowntook none of them, so its callers reached forsizeClasseswith ad hoc widths andz-50classes, the latter added to clear the Settings dialog beforeDropdownlearned to layer itself inside dialogs in #17432.This PR gives
Dropdownthe same three props with the same meaning, and moves the Settings dropdowns onto them: the Langfuse project list takessameWidth, the code environment, stateful workspace and voice lists takeminWidth, and thez-50classes the dialog layer already overrides are dropped. Fixed widths stay insizeClasses, which is what it is for. Defaults are unchanged, so dropdowns that pass none of the new props draw exactly as before.Type of change
Testing
Tested environments/configuration:
Automated tests:
dropdown-min-widthtonested-popovers.spec.ts: the Settings workspace list is at least its 18rem minimum where the viewport has room; all 26 tests in the spec pass on desktop and mobile.Dropdown.spec.tsx:minWidthis capped likeDropdownPopup's and left to the stylesheet when unset.z-50measure the same before and after (computed z-index, size, position, and on top of the dialog).Dropdownspec pass;tsc --noEmitfor both projects is clean.Screenshots / recordings
No visible change: the moved call sites resolve to the same layer and size, as measured above.
Risk / compatibility
Additive for
@librechat/client. AminWidthis now also capped to the viewport, so on a phone narrower than the requested width the list fits the screen instead of running past it. Escape in a Settings dropdown closing the whole Settings dialog predates this change and is tracked in berry-13#429.Checklist