Repository navigation
Read the system accent from the Ubuntu theme name - #18
Merged
Merged
Conversation
GNOME before 47 has no accent setting, so the desktop portal reports none and the window stayed in its own colour on Ubuntu 24.04. Ubuntu encodes the accent chosen in its settings in the GTK theme name; read it from the portal when the portal has no accent colour.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"Use the system accent colour" did nothing on Ubuntu 24.04. GNOME before 47 has no accent setting, so the desktop portal reports no
accent-color. Ubuntu encodes the accent chosen in its settings in the GTK theme name (Yaru-purple-dark), so the window now readsorg.gnome.desktop.interface gtk-themefrom the portal when the portal has no accent colour, and maps the theme's accent names to the theme's own colours.Testing
cargo clippy -p ezd-tray --all-targets -- -D warningsand thesystem_accenttests pass.Summary by CodeRabbit