Repository navigation
Add dtset (alpha): xlsx/xlsm cell writer, replacing xlset - #3
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… xlsm/xlsx output (#2) Found in final review: in-place edits reset the file mode to the umask default, overwrote 0444 files, replaced symlinks with regular files, and allowed -o to switch between .xlsm and .xlsx (producing a workbook Excel won't open). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
Ports
xlsetfrom xl-cli-tools asdtset, behind an off-by-defaultalphacargo feature. Default builds and the release binaries stay read-only:release.ymlbuilds--binswith no features and ships only dtcat, dtfilter and dtdiff.cargo install --path . --features alpha dtset file.xlsx A1=42 B2:str=07401 --sheet Revenue dtset file.xlsx --from updates.csv -o new.xlsxWhat's new compared with xlset
-oextension exits 2.-omust also keep the input's macro kind: xlsm→xlsx writes a file Excel won't open.Layout
src/edit/cell.rs: A1 parser and type inference, copied verbatim from xl-cli-tools with its unit tests.src/edit/xlsx.rs: umya-spreadsheet writer,check_editable,check_output_kind.src/bin/dtset.rs: the command-line front end.required-features = ["alpha"].tests/dtset.rs: the 11 ported xlset tests plus 5 new ones. It is gated with#![cfg(feature = "alpha")].Verification
cargo test --locked --features alpha: 274 passed.cargo test --locked(no features): 214 passed, and umya is not in the dependency tree.cargo clippy --all-targets -D warningsis clean with and withoutalpha, andcargo fmt --checkis clean.A fresh reviewer probed the binary directly: full disk, read-only directory, each non-xlsx format, formula and VBA survival, and
=or,in values. Its findings are fixed in c8a4b81.Known limitations (deferred)
--fromtreats a first row that isn't a valid cell reference as a header and skips it without a warning.Companion PR: LouLouLibs/claude-skills#17
🤖 Generated with Claude Code