Repository navigation
fix: update bitcoinjs-lib, bolt11 and tiny-secp256k1 to patch security advisories - #227
Merged
Merged
Conversation
Jossec101
approved these changes
Oct 27, 2026
imclvr
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates BitcoinJS dependencies to the patched releases from the advisories published on 2026-10-26.
No application changes needed:
SwapService.createSwapInalready uses the firstpayment_hashtag, which matches the bolt11 1.4.2 behavior.recoverorxOnlyPointAddTweakCheckfrom tiny-secp256k1 directly.The other packages in the advisories (bip39, bip38, merkle-lib, bip32-utils, tiny-secp256k1-asmjs) aren't in our dependency tree.
Testing
shared,server-backendandswap-frontendbuild.bitcoin-only.test.ts: 4/4 pass.integration.test.ts: 13 pass, 1 fails. The liquid swap-out tests fail intermittently with "insufficient funds available to construct transaction", on master as well (master: 12 pass, 2 fail).