Repository navigation
chore: share skills - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Replace four duplicated .NET skill folders with relative links to the pinned
MCCTeam/MCC-Skillssubmodule. Add Beacon, plugin and marketplace authoring links. Keep ASD-STE100 and UMPK integration testing local. Add.codex/skillalongside the existing discovery paths.Document recursive cloning, initialization, revision updates, Windows symbolic links and installation in other projects.
Versions affected
No Minecraft protocol, library version or public API changes. MCC Skills is pinned to
7761e3a8d1b493f5781ddbb34d429f3c4e4ea6d5.Evidence
Compared duplicate file inventories and hashes before removal. Three copies match the shared skill content. C# best practices has the shared repository's framework-neutral guidance. The shared SOLID skill also includes its MIT license file.
Validation
Used .NET SDK
10.0.401in the isolated branch checkout.dotnet build UMPK.sln -m:2 -p:UseSharedCompilation=false -nodeReuse:false: zero warnings and errors.dotnet test UMPK.sln --no-build -m:1 -nodeReuse:false: 12,562 passed, seven skipped, zero failures.python3 engineering/testcounts/check_test_counts.py /tmp/umpk-shared-skills-tests.log --baseline engineering/testcounts/expected_counts.json: all 17 suites match.dotnet format UMPK.sln --verify-no-changes --no-restore: exit 0. The workspace loader reported a warning.DataGen
verify --data data/java: 50 protocols pass.python3 tools/extraction/extract_lang.py --data data/java --downloads /home/anon/Minecraft/Minecraft-Console-Client/MinecraftOfficial/downloads --check: 50 protocols pass.DataGen
generate --data data/java --out src/Umpk.Data.Java --out-lang src/Umpk.Data.Lang --protocol-out src/Umpk.Protocol.Java, followed bygit diff --exit-codefor those directories: no changes.Fresh recursive clone: recorded submodule revision, seven relative shortcuts, and all nine skills resolve through all five discovery paths. The checkout is clean.
Documentation checks: 39 relative links and section anchors resolve. The new guide passes the ASD-STE100 linter.
git diff --checkpasses.Focused skill-layout checks pass.
The solution builds with no warnings.
The full test count matches the baseline.
The formatting check passes.
Data and generated files are current.
Public API files are unchanged.
The change contains no secrets, raw logs, Minecraft artifacts or unrelated changes.
Notes for reviewers
The seven skipped tests require a published AOT binary, live-server setups or decompiled source trees. Those checks were not executed. This change only affects skill discovery and documentation. Fresh-clone checks ran on Linux. The guide includes WSL and native Git for Windows setup.