Repository navigation
Conversation
|
@p3ris0n Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1253
Closes #1249
Closes #1248
Closes #1247
This PR extends GasGuard's repository analysis platform across both the Quality and Evaluation and API and Integrations workstreams. It introduces golden output snapshot verification across supported languages, a labeled benchmark corpus for analyzer rules, API deprecation and sunset policy enforcement with lifecycle headers, and end-to-end request correlation identifiers across API, worker, and RPC boundaries.
Key Implementations
1. Golden Output Snapshots for Supported Languages (Closes #1253)
file -> startLine -> startColumn -> ruleId -> message) and deterministic 16-char hex fingerprinting across multi-language scans (Solidity, Soroban Rust, Vyper, Cairo, TypeScript).added,removed,modified) across finding lists, files analyzed, and severity summaries.tenantId; write-once scan pins preserve the comparison snapshot across retries.realistic-repo-fixture.json), regression test fixture (regression-case-fixture.json), and documentation indocs/GOLDEN_OUTPUT_SNAPSHOTS.md.2. Labeled Benchmark Corpus for Analyzer Rules (Closes #1249)
docs/ANALYZER_BENCHMARK_CORPUS.md.3. API Deprecation and Sunset Policy (Closes #1248)
Deprecation: @<timestamp>,Sunset: <date>, andLink: <replacement>; rel="successor-version").gasguard_api_deprecated_route_requests_total) and structured warnings for client migration tracking.docs/API_DEPRECATION_POLICY.md.4. API Request Correlation Identifiers (Closes #1247)
X-Correlation-ID/X-Request-IDheaders or generates standardized UUIDv4 correlation IDs on ingress.scanId,correlationId).correlationIdto all log records while strictly redacting auth headers, tokens, private keys, and passwords.X-Correlation-IDin all API responses to simplify client-side tracing and support debugging.Architectural & Security Compliance
<baseDir>/<sanitized_tenantId>/...), and evaluation contexts are isolated bytenantId.ghp_*), JWTs, private keys, and repository source payloads.Verification Evidence & Test Coverage
golden-snapshot-evaluator.spec.ts(canonicalization, hashing, diffing)rule-benchmark-evaluator.spec.ts(precision/recall calculations, baseline checks)api-deprecation.middleware.spec.ts(header injection, sunset expiration dates)correlation-id.middleware.spec.ts(header validation, generation, propagation)golden-snapshot.integration.spec.ts(file-store persistence, worker task execution)correlation-id.integration.spec.ts(end-to-end trace propagation across API -> Queue -> Worker)