Repository navigation
feat(framework): an own move starts and stops on clip frames - #126
Merged
Merged
Conversation
MOVE.START is the executor's a3 on the dispatch: every part's cursor starts there, held for the blend as for any clip, and an attack before it never spawns (one at it spawns on the first playing frame). MOVE.STOP ends the move through the timed branch when PART's cursor reaches it, whatever the blend or the cursor's rate; LENGTH stays AI frames. With both 0 the move player writes what it did. MOVE grows to 0x38, so MOVE_STATE, EM_OWN, EM_MOVES and CLI_BRIDGE shift with it. ENTITY.ANIM_MODE and ANIM_SPEED are a slot's start and blend frames, not mode and speed: their docs are corrected and the names kept, as C, Lua, the HUD and the shell read them under those names. CLIP_BLOCK gains BLEND, and the cursor tests' docs say they answer 0 while a blend runs. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…'s clip frames A derived step starts its clip at the frame the donor's handler played it from and ends at the frame its handler tested when it ended the step (Step.stop: the last cursor test of the closing tick whose answer changed, its lo, or its hi for a window the cursor left). `length`, in AI frames, stays only for a step that ended on no frame of its clip (a pair, a loop, a test the cursor never changed); it no longer sets the attack windows' end, which clamp to [start, stop]. P3_OWN_START goes: a start is carried now. Manifest Move.start and Move.stop, written to the moves module; span_problems is the one place that refuses a start or stop outside the clip, a stop not after the start, or an attack window outside [start, stop], for the manifest's load and for moves.problems (derived moves skip the load). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This was referenced Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #125. Live, four of the Zinogre's derived steps never reached their attack: the donor starts clip 200 at frame 24 or 42, an own move played it from 0, and
length(AI frames) counted neither the blend (the cursor holds 2-5 frames after a dispatch) nor rage (2.8 frames a frame, not 2.0).MOVE.START/MOVE.STOP(u16 clip frames, 0 = as before;stop, sinceuntilis a Lua keyword): the clip starts at START through the executor's a3 (measured: every part starts there, no root-motion jump, events before it skipped); the move ends when the timing part's cursor reaches STOP, through the existing timed branch (AFTER,HOLD_SCRIPT, end kinds unchanged); an attack before START never spawns.MOVE0x34 → 0x38, the own-move block 19.9 → 20.3 KB.mhfu.em_move,mhfu.move_play),mhfu.live.moves(mhfu move play --start/--stop), the manifest and the moves module, with refusals (inside the clip, stop > start, attack windows inside).startfrom the donor's play,stopfrom the cursor test that ended the step;lengthonly where no clip frame ends it. Zinogre: of 75 derived moves 10 get a start, 13 a stop, 14 keep a length (27 before); the four D2 steps start at 42/24 and stop at 102/86, past their attack at 56. Brute: one start; splices unchanged.ENTITY+0x32C/+0x334 docs: the slots' start and blend frames, not mode and speed.Not here: the studio's Moves panel has no start/stop field yet, and its preview still ends a move on
length.Tests: host tests for START at the executor, STOP at blend and raised speed, the attack floor, 0/0 unchanged; pack/unpack, refusals; with game data, the D2 steps and every derived window inside
[start, stop].Live (same re-run): the first playing cursor equals START on every play of the four steps (calm 9-10, enraged 5-6 each); calm they stop exactly at STOP (102, 86), enraged within one 2.8-frame step; their attacks spawn on frame 56 every play.
🤖 Generated with Claude Code