Skip to content

fix(ppsspp-debug): a lane never logs to file #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sp00ktober wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(ppsspp-debug): a lane never logs to file #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/ppsspp-debug/src/ppsspp_debug/_lane.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,10 @@
"RemoteDebuggerOnStartup": "True",
"PauseOnLostFocus": "False",
"PauseWhenMinimized": "False",
"FileLogging": "False",
}
"""Set in a lane's ini on every start; a lane cloned from a debug-logging stick wrote GBs of
`SYSTEM/DUMP/log.txt` per session."""


@dataclass(frozen=True)
Expand Down
4 changes: 3 additions & 1 deletion packages/ppsspp-debug/tests/test_lane.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ def stick(tmp_path):
src = tmp_path / "stick"
(src / "SYSTEM").mkdir(parents=True)
(src / "SYSTEM/ppsspp.ini").write_text(
"[General]\nRemoteISOPort = 62517\nPauseOnLostFocus = True\n[Graphics]\nFrameSkip = 0\n"
"[General]\nRemoteISOPort = 62517\nPauseOnLostFocus = True\nFileLogging = True\n"
"[Graphics]\nFrameSkip = 0\n"
)
(src / "SAVEDATA/ULES01213").mkdir(parents=True)
(src / "SAVEDATA/ULES01213/DATA.BIN").write_bytes(b"save")
Expand All @@ -34,6 +35,7 @@ def test_prepare_clones_and_owns_the_port(tmp_path, stick):
assert "RemoteISOPort = 45103" in ini
assert "PauseOnLostFocus = False" in ini
assert "RemoteDebuggerOnStartup = True" in ini
assert "FileLogging = False" in ini
assert "FrameSkip = 0" in ini
assert (lane.stick / "SAVEDATA/ULES01213/DATA.BIN").read_bytes() == b"save"
assert lane.game.read_bytes() == b"iso"
Expand Down
Loading