Repository navigation
fix(mhfu): rabbitizer enums hash by value; 1.16's hash leaks an object a call - #129
Open
sp00ktober wants to merge 1 commit into
Open
sp00ktober wants to merge 1 commit into
sp00ktober wants to merge 1 commit into
Conversation
…t a call Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rabbitizer 1.16 (1.16.2 is the latest) leaks one object per
hash()of any of its enums (registers,InstrId). The walkers key their state by registers and test instruction ids against sets, so one Zinogre derivation held 10-13 GB and a suite run in one process far more (four such processes took a 32 GB Mac down).mhfu.mipsgivesrabbitizer.Enuma hash by value (agrees with==).mhfu.mips(each in its own process).Peaks with data:
test_zinogre_brain.py0.29 GB (was over 8 GB for one of its tests), mhfu suite 0.70 GB, mhfu-port suite 0.46 GB. mhfu 1650 passed; mhfu-port 999 passed + the 6 raw-file tests with.../data_files.🤖 Generated with Claude Code