AEAD lifecycle/API: tag after Done, EncodeAuthenticated, CCM via Done - #105
Merged
MHumm merged 1 commit intoSep 16, 2026
Merged
Conversation
Follow-up to PR MHumm#102 (points 1, 3, 5, 6). Reading CalculatedAuthenticationTag before Done now raises EDECCipherException. Protected EncodeGCM/EncodeCCM are unified as EncodeAuthenticated (Decode counterpart too). CCM materializes the authentication tag in Done so GCM and CCM share one lifecycle. Modes without prescribed tag lengths document returning an empty array. Co-authored-by: Olaf Monien <omonien@users.noreply.github.com>
This was referenced Sep 15, 2026
Owner
|
Brauchen wir bei den GCM Unit Tests auch einen Idempotenz Test? |
Contributor
Author
|
Hallo Markus, danke fürs Mergen! Den Idempotenz-Test für GCM gibt es bereits: Wenn du etwas anderes meintest (z. B. Idempotenz von Encode-Chunks), sag Bescheid. Viele Grüße |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #102, split as Markus requested (“Gerne in 2 PR”).
Companion: CCM multi-chunk / spec (open after this merges).
CalculatedAuthenticationResultbeforeDonemust raise (hard check, not Assert)EDECCipherExceptionuntilDoneEncodeGCM/EncodeCCM→EncodeAuthenticatedDonelike GCMT XOR S_0) materialized inTCCM.Done[0]Lifecycle:
Init → AAD/tag length → Encode/Decode* → Done → read tagTests added for before-Done raises and Done idempotency; RFC 3610 CCM vectors call
Donebefore reading the tag.Out of scope: ChaCha/Poly1305 (#90); CCM multi-chunk / InitMode 128-bit (companion PR).