CCM: harden DeclarePayloadLength (follow-up to #106) - #107
Merged
MHumm merged 1 commit intoSep 18, 2026
Merged
Conversation
Make TCCM.DeclarePayloadLength fail hard after start or when a different length is declared, while still allowing an idempotent re-declare of the same length. EncodeStream only auto-declares when no length is set yet so multi-chunk streams keep working. Follow-up to MHumm#106. Co-authored-by: Olaf Monien <omonien@users.noreply.github.com>
This was referenced Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #106 — Markus’ consistency point on
DeclarePayloadLength.Change
TCCM.DeclarePayloadLengthno longer silently ignores illegal calls:Done→ still raises viaCheckNotFinalizedEDECCipherException(sCCMPayloadLengthAlreadyDeclared)EDECCipherException(sCCMPayloadLengthLocked)Also:
EncodeStreamonly auto-declares length when none is set yet, so multi-chunk streams that already setAuthenticatedPayloadLengthkeep working with the stricter rules.SupportsMultiChunkstays a Boolean (no capability set yet).Tests
TestDECCipherModesCCM.pas: same length, different length, after Encode, after Decode, after Done.No Delphi compiler in this agent environment — changes follow existing exception/
CreateRespatterns in the unit.