Conversation
❌ 3 blocking issues (3 total)
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| creator_link = normalized[:creators].first[:link] | ||
| assert_match 'discovery/search?query=creator,exact,', creator_link | ||
| assert_match 'Smith%2C%20John%20A.', creator_link | ||
| assert_match 'nde/search?vid=01MIT_INST:NDE&search_scope=all&mode=advanced&tab=all&query=creator,exact,Smith%2C%20John%20A.&offset=0&lang=en', |
Coverage Report for CI Build 31437235838Coverage decreased (-0.002%) to 98.324%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
matt-bernhardt
approved these changes
Aug 10, 2026
matt-bernhardt
left a comment
matt-bernhardt
left a comment
Member
There was a problem hiding this comment.
I'm approving this, but I do wonder about whether a hard-coded tab value is going to be what we want long term (or maybe we already talked about this and all is the only value we want to support for NDE)
| ENV.fetch('PRIMO_NDE_VID'), | ||
| '&search_scope=all', | ||
| '&mode=advanced', | ||
| '&tab=all', |
Member
There was a problem hiding this comment.
This is the only thing that gives me pause, because we're moving from reading PRIMO_TAB to a hard-coded all
Contributor
Author
There was a problem hiding this comment.
Good call. I'll revert that before merging.
Why these changes are being introduced: Primo NDE has made multiple changes to how advanced search links are structured. This has caused our author search links to fail. Relevant ticket(s): - [USE-681](https://mitlibraries.atlassian.net/browse/USE-681) How this addresses that need: This restructures the author links to match Primo NDE links. Side effects of this change: Depending on how the author name is structured, relevant results might be omitted from the query. For example, "Weigel, Moira 1984- author." returns only one result in NDE, whereas "Weigel, Moira" returns many more (all of which seem relevant). We will open a ticket to determine whether it's worth trying to modify author link search terms for broader results.
Revert to reading tab value from env
| '&query=creator,exact,', | ||
| URI.encode_uri_component(author), | ||
| '&offset=0', | ||
| '&lang=en'].join |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
Primo NDE has made multiple changes to how
advanced search links are structured. This has
caused our author search links to fail.
Relevant ticket(s):
How this addresses that need:
This restructures the author links to match
Primo NDE links.
Side effects of this change:
Depending on how the author name is structured,
relevant results might be omitted from the query.
For example, "Weigel, Moira 1984- author."
returns only one result in NDE, whereas
"Weigel, Moira" returns many more (all of which
seem relevant).
We will open a ticket to determine whether it's
worth trying to modify author link search terms
for broader results.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
E.g., if the PR includes updated dependencies and/or data
migration, or how to confirm the feature is working.
Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing