Conversation
Why these changes are being introduced: Primo NDE internally replaces commas in advanced search query terms with the box drawings light horizontal character (U+2500). It then converts that character back into a comma for the search summary. In order for our author searches to look normal in the NDE search summary, we need to replace them with this specific character in the URL. Relevant ticket(s): - [USE-681](https://mitlibraries.atlassian.net/browse/USE-681) How this addresses that need: This replaces commas with U+2500 in author link search terms. Side effects of this change: Ex Libris will probably change this again someday without telling anyone.
Coverage Report for CI Build 31513139623Coverage increased (+0.003%) to 98.327%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
❌ 3 blocking issues (3 total)
|
![qltysh[bot]](https://avatars.githubusercontent.com/in/890766?s=60&v=4){kind=small}
| URI.encode_uri_component(author), | ||
| encode_author(author), | ||
| '&offset=0', | ||
| '&lang=en'].join |
| normalized = NormalizePrimoRecord.new(full_record, 'test').normalize | ||
| creator_link = normalized[:creators].first[:link] | ||
| assert_match 'nde/search?vid=01MIT_INST:NDE&search_scope=all&mode=advanced&tab=all&query=creator,exact,Smith%2C%20John%20A.&offset=0&lang=en', | ||
| assert_match 'nde/search?vid=01MIT_INST:NDE&search_scope=all&mode=advanced&tab=all&query=creator,exact,Smith%E2%94%80%20John%20A.&offset=0&lang=en', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why these changes are being introduced:
Primo NDE internally replaces commas in advanced
search query terms with the box drawings light
horizontal character (U+2500). It then converts
that character back into a comma for the search
summary.
In order for our author searches to
look normal in the NDE search summary, we need
to replace them with this specific character
in the URL.
Relevant ticket(s):
How this addresses that need:
This replaces commas with U+2500 in author link
search terms.
Side effects of this change:
Ex Libris will probably change this again someday
without telling anyone.
Developer
Accessibility
New ENV
Approval beyond code review
Additional context needed to review
When you follow a link to an author search in NDE, the search summary should show commas, not horizonal lines/emdashes or
search-advanced.boolOperator.option..Code Reviewer
Code
added technical debt.
Documentation
(not just this pull request message).
Testing