Skip to content

Retire the paid FiveM shop, scripts are free on GitHub - #66

Merged
Musiker15 merged 1 commit into
mainfrom
feature/free-fivem-scripts
Nov 5, 2026
Merged

Musiker15 merged 1 commit into
mainfrom
feature/free-fivem-scripts

Conversation

@Musiker15

Copy link
Copy Markdown
Member

MSK Garage, MSK Handcuffs and MSK VehicleKeys are free on GitHub now, and the all-access subscription goes with them. Once this is deployed, all Tebex packages get disabled. This PR switches the paid shop off. It does not remove the Tebex code yet, that comes in a separate cleanup.

What changes

Redirects (lib/routes.ts, retiredRedirect)

  • /fivem/garage, /fivem/handcuffs, /fivem/vehiclekeys answer 301 with https://github.com/MSK-Scripts/msk_<name>, /fivem/all-access (/de/fivem/alle-scripts) with https://github.com/MSK-Scripts. This covers the /en, /de and unprefixed forms.
  • Every old address with one of the eight Tebex package ids (/packages/<id>, /package/<id>, /fivem/<id>, with or without language) answers 301 with the same repository. The ids live in the new lib/retiredProducts.ts, because resource-stats no longer lists them and SUBSCRIPTION_PACKAGE_IDS is now null.
  • The redirect runs before the proxy asks Tebex, so it also holds while Tebex still lists the packages.
  • The query string of the old address is not appended to the GitHub URL. ?variant=source means nothing there.
  • The catalogue /fivem, the category pages, /cart and /checkout answer 308 with /fivem/free (/de/fivem/kostenlos) in the same language.

Content and navigation

  • content/resource-stats.ts: the three scripts are tier: "free" with their GitHub link.
  • content/custom-packages.ts: the three scripts are listed on /fivem/free and in the homepage free scripts section, with docs links (checked, all three return 200).
  • Header: no cart button. The site layout drops the cart drawer and the sale price fetcher.
  • FiveM nav line, footer, hero, about page and 404 page point to /fivem/free. The nav entries "Paid scripts" and "All-access subscription" are gone.
  • Homepage: the paid catalogue section is gone, and with it the Tebex fetch. The hero shows "Free, open source on GitHub" instead of the cheapest Tebex price.
  • Texts that mentioned "the paid scripts" or escrow releases (home meta description, free page description, free scripts intro) are updated in both languages.
  • Sitemap and llms.txt no longer list product or category pages and no longer call Tebex.

Left on purpose

  • Tebex client, lib/products.ts, basket API routes, cart store, /auth/discord, the env variables and the now unreachable pages and components (fivem/page.tsx, fivem/[slug], fivem/all-access, fivem/categories/[id], cart, checkout, components/home/Catalog.tsx, the cart and product components) stay for the cleanup PR. Their route table entries also stay, so the German addresses still resolve and redirect.
  • The shop sign-in (CFX.re through Tebex) in the account menu, /account and /login is unchanged. Those pages mix Tebex with the bot logins, and the account page still links buyers to their Tebex payment history and the Keymaster.
  • Footer trust line, payment marks on / and /fivem/*, and "Powered by Tebex" are unchanged. They are legal or Tebex wording and belong to the cleanup.
  • robots.txt still disallows /cart and /checkout. Harmless now that both only redirect.
  • Nothing Stripe or ticket bot related is touched.

Tests

  • New retired shop tests in tests/routes.test.ts: every slug and every package id, under every old scheme and both languages, gives 301 to the right GitHub URL, plus the 308s for catalogue, categories, cart and checkout. I broke the handcuffs mapping once on purpose, the test went red, then restored it.
  • tests/notFoundPage.test.ts checks the 301 through the real proxy and that the query is dropped (also checked red with the fix removed).
  • The product model tests (products.test.ts, cart.test.ts) run against the last paid configuration from tests/fixtures/paidCatalogue.ts, since that code stays until the cleanup.
  • Sitemap and llms.txt tests updated for the removed entries.

Locally: npm run typecheck, npm run lint, npm test (90 files, 1501 tests) and npm run build all pass.

MSK Garage, MSK Handcuffs and MSK VehicleKeys move to the free tier and
the all-access subscription is switched off. Nothing is sold through Tebex
any more, so the parts of the shop that only made sense with something to
buy redirect or disappear:

- /fivem/garage, /fivem/handcuffs, /fivem/vehiclekeys and
  /fivem/all-access answer 301 with the GitHub repository (the org for
  the subscription), in both languages and for every old address with a
  Tebex package id (/packages/<id>, /package/<id>, /fivem/<id>). The ids
  are kept in lib/retiredProducts.ts. The query of the old address is not
  carried over to GitHub.
- The catalogue, the category pages, cart and checkout answer 308 with
  the free scripts page of the same language.
- Header, footer, mobile menu, hero, about and 404 page link to the free
  scripts instead of the catalogue. The cart button, cart drawer and sale
  price fetcher are gone from the layout, the paid catalogue from the
  homepage.
- The three scripts are listed on /fivem/free and the homepage with
  their docs links. Sitemap and llms.txt no longer list product or
  category pages and no longer call Tebex.

The Tebex client, the product model, the basket API and the old pages
stay in the code for a separate cleanup. Their tests run against the last
paid configuration (tests/fixtures/paidCatalogue.ts).
@graphify-labs

graphify-labs Bot commented Nov 5, 2026

Copy link
Copy Markdown

Graphify reviews are paused for this workspace because nobody has used it in 7 days. A workspace owner can resume reviews from the Repositories page: https://app.graphify.com/msk-scripts/repositories

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage/vitest

main 6567fde feature/free-fivem-s... 1806bf1 +/-
73% 73% 0%
View coverage of the 6 most impacted files.
File main 6567fde feature/free-fivem-s... 1806bf1 +/-
lib/productView.ts 74% 63% -11%
lib/sitemap.ts 95% 92% -3%
lib/routes.ts 99% 99% 0%
lib/llms.ts 100% 100% 0%
lib/products.ts 100% 100% 0%
lib/retiredProducts.ts 0% 100% +100%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

@Musiker15
Musiker15 merged commit ba23e3f into main Nov 5, 2026
11 checks passed
@Musiker15
Musiker15 deleted the feature/free-fivem-scripts branch November 5, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant