Repository navigation
Retire the paid FiveM shop, scripts are free on GitHub - #66
Merged
Merged
Conversation
MSK Garage, MSK Handcuffs and MSK VehicleKeys move to the free tier and the all-access subscription is switched off. Nothing is sold through Tebex any more, so the parts of the shop that only made sense with something to buy redirect or disappear: - /fivem/garage, /fivem/handcuffs, /fivem/vehiclekeys and /fivem/all-access answer 301 with the GitHub repository (the org for the subscription), in both languages and for every old address with a Tebex package id (/packages/<id>, /package/<id>, /fivem/<id>). The ids are kept in lib/retiredProducts.ts. The query of the old address is not carried over to GitHub. - The catalogue, the category pages, cart and checkout answer 308 with the free scripts page of the same language. - Header, footer, mobile menu, hero, about and 404 page link to the free scripts instead of the catalogue. The cart button, cart drawer and sale price fetcher are gone from the layout, the paid catalogue from the homepage. - The three scripts are listed on /fivem/free and the homepage with their docs links. Sitemap and llms.txt no longer list product or category pages and no longer call Tebex. The Tebex client, the product model, the basket API and the old pages stay in the code for a separate cleanup. Their tests run against the last paid configuration (tests/fixtures/paidCatalogue.ts).
|
Graphify reviews are paused for this workspace because nobody has used it in 7 days. A workspace owner can resume reviews from the Repositories page: https://app.graphify.com/msk-scripts/repositories |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage/vitest
View coverage of the 6 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSK Garage, MSK Handcuffs and MSK VehicleKeys are free on GitHub now, and the all-access subscription goes with them. Once this is deployed, all Tebex packages get disabled. This PR switches the paid shop off. It does not remove the Tebex code yet, that comes in a separate cleanup.
What changes
Redirects (lib/routes.ts,
retiredRedirect)/fivem/garage,/fivem/handcuffs,/fivem/vehiclekeysanswer 301 withhttps://github.com/MSK-Scripts/msk_<name>,/fivem/all-access(/de/fivem/alle-scripts) withhttps://github.com/MSK-Scripts. This covers the/en,/deand unprefixed forms./packages/<id>,/package/<id>,/fivem/<id>, with or without language) answers 301 with the same repository. The ids live in the newlib/retiredProducts.ts, because resource-stats no longer lists them andSUBSCRIPTION_PACKAGE_IDSis nownull.?variant=sourcemeans nothing there./fivem, the category pages,/cartand/checkoutanswer 308 with/fivem/free(/de/fivem/kostenlos) in the same language.Content and navigation
content/resource-stats.ts: the three scripts aretier: "free"with their GitHub link.content/custom-packages.ts: the three scripts are listed on/fivem/freeand in the homepage free scripts section, with docs links (checked, all three return 200)./fivem/free. The nav entries "Paid scripts" and "All-access subscription" are gone.Left on purpose
lib/products.ts, basket API routes, cart store,/auth/discord, the env variables and the now unreachable pages and components (fivem/page.tsx,fivem/[slug],fivem/all-access,fivem/categories/[id],cart,checkout,components/home/Catalog.tsx, the cart and product components) stay for the cleanup PR. Their route table entries also stay, so the German addresses still resolve and redirect./accountand/loginis unchanged. Those pages mix Tebex with the bot logins, and the account page still links buyers to their Tebex payment history and the Keymaster./and/fivem/*, and "Powered by Tebex" are unchanged. They are legal or Tebex wording and belong to the cleanup.robots.txtstill disallows/cartand/checkout. Harmless now that both only redirect.Tests
retired shoptests intests/routes.test.ts: every slug and every package id, under every old scheme and both languages, gives 301 to the right GitHub URL, plus the 308s for catalogue, categories, cart and checkout. I broke the handcuffs mapping once on purpose, the test went red, then restored it.tests/notFoundPage.test.tschecks the 301 through the real proxy and that the query is dropped (also checked red with the fix removed).products.test.ts,cart.test.ts) run against the last paid configuration fromtests/fixtures/paidCatalogue.ts, since that code stays until the cleanup.Locally:
npm run typecheck,npm run lint,npm test(90 files, 1501 tests) andnpm run buildall pass.