Skip to content

Show Discord members instead of shop buyers, center the proof line - #67

Merged
Musiker15 merged 1 commit into
mainfrom
feature/proof-discord-members
Nov 5, 2026
Merged

Musiker15 merged 1 commit into
mainfrom
feature/proof-discord-members

Conversation

@Musiker15

Copy link
Copy Markdown
Member

The figures under the hero still showed "unique buyers" from the Tebex snapshot. The shop doesn't sell FiveM scripts anymore, so that number now only describes the past. Support runs through the Discord now, so its member count takes the slot.

Home page. The proof line shows Discord members (linked to the invite), servers running msk_core and documentation pages. It is now centered instead of left aligned.

About page. Unique buyers, the refund rate, the first sale and the "shop figures as of" note are gone. Discord members join servers and docs pages.

Source. The count comes from Discord's public invite endpoint (/invites/<code>?with_counts=true, no token), fetched on the server and cached for an hour. It is the same number Discord shows on the invite card. If the lookup fails or returns something odd, the entry drops out like the other two. Nothing is estimated.

lib/shopStats.ts and scripts/tebex-stats.js stay for now. They belong to the Tebex cleanup.

Tests: new tests/discordMembers.test.ts for the invite code and the parser (I broke the zero check once on purpose and the test went red). tests/aboutFigures.test.ts is rewritten for the new list. Typecheck, lint, npm test (1504 passed) and next build pass locally.

@graphify-labs

graphify-labs Bot commented Nov 5, 2026

Copy link
Copy Markdown

Graphify reviews are paused for this workspace because nobody has used it in 7 days. A workspace owner can resume reviews from the Repositories page: https://app.graphify.com/msk-scripts/repositories

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown

⚠️ Deprecation Warning: The deny-licenses option is deprecated for possible removal in the next major release. For more information, see issue 997.

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@github-code-quality

Copy link
Copy Markdown

Code coverage overview

Languages: TypeScript

TypeScript / code-coverage/vitest

main ba23e3f feature/proof-discor... 4d416cd +/-
73% 73% 0%
View coverage of the 2 most impacted files.
File main ba23e3f feature/proof-discor... 4d416cd +/-
lib/aboutFigures.ts 100% 100% 0%
lib/discordMembers.ts 0% 37% +37%

ℹ️ Calculations represent line coverage. Results may change as calculations are updated.

@Musiker15
Musiker15 merged commit 5f86460 into main Nov 5, 2026
11 checks passed
@Musiker15
Musiker15 deleted the feature/proof-discord-members branch November 5, 2026 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant