Repository navigation
Show Discord members instead of shop buyers, center the proof line - #67
Merged
Merged
Conversation
|
Graphify reviews are paused for this workspace because nobody has used it in 7 days. A workspace owner can resume reviews from the Repositories page: https://app.graphify.com/msk-scripts/repositories |
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
Code coverage overviewLanguages: TypeScript TypeScript / code-coverage/vitest
View coverage of the 2 most impacted files.
ℹ️ Calculations represent line coverage. Results may change as calculations are updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The figures under the hero still showed "unique buyers" from the Tebex snapshot. The shop doesn't sell FiveM scripts anymore, so that number now only describes the past. Support runs through the Discord now, so its member count takes the slot.
Home page. The proof line shows Discord members (linked to the invite), servers running msk_core and documentation pages. It is now centered instead of left aligned.
About page. Unique buyers, the refund rate, the first sale and the "shop figures as of" note are gone. Discord members join servers and docs pages.
Source. The count comes from Discord's public invite endpoint (
/invites/<code>?with_counts=true, no token), fetched on the server and cached for an hour. It is the same number Discord shows on the invite card. If the lookup fails or returns something odd, the entry drops out like the other two. Nothing is estimated.lib/shopStats.tsandscripts/tebex-stats.jsstay for now. They belong to the Tebex cleanup.Tests: new
tests/discordMembers.test.tsfor the invite code and the parser (I broke the zero check once on purpose and the test went red).tests/aboutFigures.test.tsis rewritten for the new list. Typecheck, lint,npm test(1504 passed) andnext buildpass locally.