Repository navigation
Confirm before converting tasks and headings to projects - #230
Merged
Merged
Conversation
MaplumeX
force-pushed
the
feat/task-title-project-double-confirm
branch
from
October 13, 2026 12:48
1136b73 to
e2f3cd9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converting a task or a project heading into a project is destructive and irreversible — the source is physically deleted (ADR-0024). Previously a task with no attachments converted immediately with no confirmation, and a heading converted straight from the actions menu with no warning about its tasks being moved. This adds an explicit confirmation step to both paths.
Changes
useConvertGuard): always show a confirmation dialog instead of skipping it when there are no attachments. The copy now branches — the attachment-specific warning (convertWithAttachments, ADR-0019) when attachments exist, otherwise the new genericconvertConfirmtext. The confirm button staysdestructiveonly when attachments will be deleted, otherwisedefault. Keeps the last attachment count in a ref so the description doesn't flicker back during the close animation.ProjectHeadingRow): selecting "Convert to Project" now opens a confirmation dialog (convertHeadingConfirm) explaining that the heading becomes a new project and its tasks move into it. The mutation only runs after confirming.convertConfirmandconvertHeadingConfirmstrings for bothenandzh.Testing
ProjectHeadingRow.test.tsxto assert the mutation is not called on menu select and is called after confirming in the dialog.