Repository navigation
Rework mobile settings lists into Material 3 Expressive segments - #233
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The narrow-screen settings skeleton was still iOS inset-grouped: a gray page with white rounded cards, hairline dividers between rows, and current values trailing at the end of the row. This replaces that skeleton with the segmented list style of Android 16 system settings (Material 3 Expressive). Navigation stack, back behavior, and the desktop settings dialog are unchanged.
Spec:
.scratch/mobile-settings-m3-expressive/spec.mdChanges
SettingsRow.value)Implementation notes
SettingsGroup's row container via[&>*], so it applies to direct children — either the row itself or a wrapper (e.g. the notification-reliabilitydata-testidwrapper). Individual settings pages needed no changes.SettingsGroupgained aroleprop;SettingsOptionGroupand the time zone picker now putradiogroupon the row container, making each option button a direct child and therefore its own tile.max-md:; desktop keeps the original 36×20 switch.Testing
Out of scope