DRAFT | MDEV-35026 - DROP CONSTRAINT for self referencing FK fails without error, but modifies another UNIQUE KEY definied with USING HASH#5380
Draft
pranavktiwari wants to merge 2 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies sql/sql_table.cc to adjust how the key algorithm is determined during an alter table preparation. Specifically, when the key algorithm is HA_KEY_ALG_LONG_HASH, it is now set to HA_KEY_ALG_HASH if either fast_alter_partition is active or if the ALTER_CHANGE_COLUMN flag is not set. There are no review comments, and I have no additional feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.