Repository navigation
Feat/codemirror v6 #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Feat/codemirror v6 #173
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
be7c2a6
feat(yasqe): migrate editor to CodeMirror 6
MathiasVDA f1673d3
feat(yasr): render response plugin with CodeMirror 6
MathiasVDA 0d25518
feat(yasgui): adapt tabs and themes to the CodeMirror 6 editor
MathiasVDA 428ab0d
test: adapt e2e tests to CodeMirror 6 DOM and API
MathiasVDA 37b7cab
docs: document the CodeMirror 6 editor architecture and add changeset
MathiasVDA aa2b79d
fix(yasr): set min-height to 0 and enable overflow for results contai…
MathiasVDA 549b9fd
feat(yasgui): add additional CodeMirror 6 themes and syntax error hig…
MathiasVDA 909639b
feat(yasr): reimplement language support for ttl
MathiasVDA File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| --- | ||
| "@matdata/yasqe": major | ||
| "@matdata/yasr": major | ||
| "@matdata/yasgui": major | ||
| --- | ||
|
|
||
| Migrate the editor stack from CodeMirror 5 to CodeMirror 6. | ||
|
|
||
| **@matdata/yasqe** | ||
|
|
||
| - The query editor now runs on CodeMirror 6 (`@codemirror/state`, `@codemirror/view`, `@codemirror/language`, `@codemirror/autocomplete`, `@codemirror/search`, `@codemirror/commands`). | ||
| - `Yasqe` no longer extends the CodeMirror class. It wraps an `EditorView` and exposes a CodeMirror 5–compatible facade (`getValue`, `setValue`, `getCursor`, `setCursor`, `getTokenAt`, `getDoc`, `markText`, `on('change' | 'cursorActivity' | ...)`, `addKeyMap`, ...). Code relying on CodeMirror 5 internals (`yasqe.display`, `CodeMirror.defineMode`, addons, `codemirror/theme/*.css`) must be updated. | ||
| - The underlying `EditorView` is available for advanced integrations that want to use CodeMirror 6 extensions directly. | ||
| - Syntax highlighting, error/warning gutter markers, PREFIX/brace folding, autocompletion popups (`.CodeMirror-hints`), formatting, comment toggling and all keyboard shortcuts keep their previous behaviour. Token CSS classes keep the CodeMirror 5 names (`cm-keyword`, `cm-variable-3`, ...), and the editor root still carries the `CodeMirror cm-s-<theme>` classes so existing theme stylesheets continue to apply. | ||
|
|
||
| **@matdata/yasr** | ||
|
|
||
| - The Response plugin renders raw responses with a read-only CodeMirror 6 view (`@codemirror/lang-json`, `@codemirror/lang-xml`, legacy Turtle mode) instead of CodeMirror 5. | ||
|
|
||
| **@matdata/yasgui** | ||
|
|
||
| - Adapted to the new editor API (Ctrl/Cmd-click IRI navigation, theme handling). | ||
| - The editor theme picker now offers the bundled `default` and `github-dark` themes; the CodeMirror 5 theme catalogue (`material-palenight`, `dracula`, ...) is no longer shipped. Custom themes can be added by styling the `cm-s-<name>` class. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.