Skip to content

persist attack through attacker transformation #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
drbergman wants to merge 2 commits into
base: development
Choose a base branch
from
Open

persist attack through attacker transformation #341

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc6b4ae
persist attack through attacker transformation
drbergman Aug 16, 2026
1855646
carry total_damage_delivered across transformation
drbergman Aug 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions core/PhysiCell_cell.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1158,12 +1158,14 @@ void Cell::convert_to_cell_definition( Cell_Definition& cd )
Molecular cell_molecular = phenotype.molecular;
Custom_Cell_Data cell_custom_data = custom_data;

// pAttackTarget is phenotype state, and the assignment below replaces it, so
// end this cell's own attack. attacked_by and the spring are in state, which
// transformation preserves, so attacks against this cell continue.
remove_self_from_attacked();
// should we also remove all attackers? That would be a change in behavior, so for now we don't.
// remove_all_attackers();
// pAttackTarget is phenotype state, and the assignment below replaces it, so hold
// on to it and put it back afterwards. attacked_by and the spring are in state,
// which transformation preserves, so restoring pAttackTarget keeps the whole
// attack link intact -- matching attacks against this cell, which already persist.
Cell* cell_attack_target = phenotype.cell_interactions.pAttackTarget;
// a lifetime tally of this cell's own doing, so carry it across the transformation
// rather than restarting it partway through an attack that is still running
double cell_total_damage_delivered = phenotype.cell_interactions.total_damage_delivered;

// use the cell defaults;
type = cd.type;
Expand All @@ -1184,6 +1186,8 @@ void Cell::convert_to_cell_definition( Cell_Definition& cd )

phenotype.geometry = cell_geometry; // leave the geometry alone
phenotype.molecular.internalized_total_substrates = cell_molecular.internalized_total_substrates;
phenotype.cell_interactions.pAttackTarget = cell_attack_target; // leave any ongoing attack alone
phenotype.cell_interactions.total_damage_delivered = cell_total_damage_delivered;

for( int nn = 0 ; nn < custom_data.variables.size() ; nn++ )
{
Expand Down
Loading