Skip to content

fix(analysis): show the Exaflow message for a 422 response #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KFilippopolitis merged 1 commit into from
Nov 12, 2026
Merged

fix(analysis): show the Exaflow message for a 422 response #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/hbp/mip/algorithm/AnalysisService.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public AnalysisResultDTO runAnalysis(UUID requestId, AnalysisRequestDTO analysis
static Object convertResponseToAnalysisResult(Logger logger, int code, StringBuilder responseBody) {
return switch (code) {
case 200 -> new RawJson(responseBody.toString());
case 400, 413, 460, 461, 462, 512, 513 -> convertExaflowResponseToAnalysisResult(responseBody.toString());
case 400, 413, 422, 460, 461, 462, 512, 513 -> convertExaflowResponseToAnalysisResult(responseBody.toString());
case 500 -> convertExaflowResponseToAnalysisResult(GENERIC_ERROR_MESSAGE);
// Exaflow is at its concurrent-analysis limit; its own message names internal components,
// so it goes to the log and the user gets a retry message.
Expand Down
8 changes: 8 additions & 0 deletions src/test/java/hbp/mip/algorithm/AnalysisServiceRequestIdTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,4 +52,12 @@ void convertResponse_passesExaflowMessageTooLargeThrough() {
assertThat(AnalysisService.convertResponseToAnalysisResult(new Logger("user", "test"), 413, exaflowBody))
.isEqualTo(Map.of("data", exaflowBody.toString(), "type", "text/plain+error"));
}

@Test
void convertResponse_passesExaflowMalformedRequestThrough() {
var exaflowBody = new StringBuilder("Request malformed:\nbody.inputdata: Field required");

assertThat(AnalysisService.convertResponseToAnalysisResult(new Logger("user", "test"), 422, exaflowBody))
.isEqualTo(Map.of("data", exaflowBody.toString(), "type", "text/plain+error"));
}
}
Loading