Repository navigation
feat(account): move remote-access instructions to their own page - #77
Merged
Merged
Conversation
Keep the profile page to the access token and a link out to /account/remote-access, with Linux/macOS and Windows command variants.
…lback rule The nominal-column flow filled an 'Otherwise' fallback field that the studio no longer has and expected the folded nominal card's rule to stay visible after K-means was added. It now adds the column without a fallback, expects no default_enumeration in the request, and reopens the nominal card before reading its rule.
…sessionStorage The component spec throttled the redirect through sessionStorage, which every spec file in the Vitest browser page shares. hub-session.spec clears it while notebook.component.spec is waiting, so the redirect could fire and pull the iframe away (Cannot connect to the iframe). The specs now mark the component's page as gone instead, so ensureHubSession answers failed and never navigates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/account) keeps only the access-token section plus a button to the setup instructions./account/remote-accessholds the Linux/macOS and Windows client setup steps, with OS-aware defaults and a link back to create a token.copyToClipboardhelper extracted for both pages./services/auth-configis missing, the profile hides the token section as before; the instructions page shows that remote access is unavailable.Test plan
/accountwith auth-config present: token section and "Setup instructions" button visible/account/remote-access: Linux/macOS and Windows toggles switch command syntax/accountnpm run verifyand account-page / remote-access-guide specs