Repository navigation
perf(gota): skip visibility checks for worse targets - #99
Merged
Merged
Conversation
macromackie
marked this pull request as ready for review
October 9, 2026 05:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GotA target acquisition checks visibility even for enemies that cannot beat the current nearest target. Moving the read-only visibility lookup after the existing distance and tie predicate skips those unnecessary lookups in footman and hero acquisition. Scan order, tie rules, and target updates stay unchanged.
Manual Tests
02eda3d; the target-selection source and dependencies are unchanged on this PR's base179603b.Measurement report, raw samples, patch, and build identity (organization access required).
[Prepared with Codex]