Repository navigation
Conversation
- Require PHP ^8.2; fix ext-pcntl/ext-posix constraints that blocked PHP 8 - Bump predis to ^3.3, ramsey/uuid ^4.7, laminas-eventmanager ^3.13, allow psr/container 2 and psr/log 2/3 - Replace strftime() (deprecated in 8.1) with date() - Make Job's $id parameter explicitly nullable (8.4 deprecation) - Add typed properties and return types; make JobManager constants public - Return [] from RedisAdapter::getStatus() for unknown jobs instead of a TypeError - Replace Travis, GrumPHP, Code Climate and Super-Linter with one GitHub Actions workflow; add Dependabot config - Port php-cs-fixer config to v3 and PHPStan config to v2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Dev tooling (composer-require-checker) pulls in an abandoned package, which failed the audit without affecting library users. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
QueueJitsu hasn't been touched since 2020. It still targets PHP 7.2, and its
ext-pcntl: ^7.2constraint means Composer refuses to install it on PHP 8 at all. On PHP 8.5 it throws 18 deprecation notices per run. CI runs on Travis and GrumPHP, and both have stopped working.This moves the library to PHP 8.2+ (the oldest PHP still getting security fixes), fixes the deprecations, and swaps the tooling for one GitHub Actions workflow. It breaks backwards compatibility, so it should ship as 5.0.0.
Smaller changes:
psr/http-message ^1.0, but itsStream::seek()fatals against 1.0. Hence theconflict. I hit this in the lowest-deps run.Worker::__invoke()takesint|string.mez/queuejitsu-clipasses the interval straight from a Symfony Console option, which is a string.composer checknow runs validate, normalize, php-cs-fixer, PHPStan level 8 and composer-require-checker.tearDownsaidsetUp. Fixed.failed_atandworker:*:startednow include the timezone.strftime('%Z')was printing nothing.Evidence
I couldn't use Docker here, so I ran static PHP 8.2.32 and 8.5.8 builds against Valkey 9.1.3 built from source.
The smoke test enqueues a job that succeeds and one that throws, runs the forking worker, sends SIGQUIT, then reads the statuses and the failure record back from Redis.
strftime(),Job::__constructand Predis 1.x.failed_at=Wed Oct 28 17:34:28 2026has an empty timezone.After (8.2, 8.5, and 8.2 with
--prefer-lowest):ok status=4 fail status=3 processed=2,failed_at=Wed Oct 28 17:38:05 UTC 2026, 0 notices.getStatus()for an unknown job fails withTypeError: json_decode(): Argument #1 ($json) must be of type string, null given.After: returns
[].Fatal error: Declaration of Predis\Connection\Resource\Stream::seek(...) must be compatible with Psr\Http\Message\StreamInterface::seek(...).After: psr/http-message resolves to 1.1 and the smoke test passes.
composer checkpasses on 8.2. PHPStan level 8 reports no errors on 8.5 or on 8.2 with lowest deps.composer auditfinds no advisories.Merge Danger
Door: two-way while unreleased. Tagging 5.0.0 makes it one-way, because Packagist users will pick it up.
Blast Radius: anyone on PHP < 8.2, or anyone pinning Predis 1/2.
mez/queuejitsu-clirequiresmez/queuejitsu ^4andpredis ^1.1, so it needs its own bump before it can use this. Subclasses ofAbstractWorkerorWorkerthat redeclare the now-typed protected properties need types too.Once this merges, the open Dependabot PRs #28, #29, #30, #31 and #32 are obsolete.
Reviewed with review-loop: 1 round with GPT-6.1 Sol. Verdict: approved
Created with Claude Opus 5.5 in Claude Code (T3 Code).
🤖 Generated with Claude Code