Refactor wrapper startup through deterministic main.py bootstrap - #25
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b77f96db3a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
|
|
||
| def _is_host_like_host(host: str) -> bool: | ||
| return host == "localhost" or "." in host or bool(_IPV4_RE.fullmatch(host)) or _is_bracketed_ipv6(host) |
There was a problem hiding this comment.
The new URL normalizer only treats hosts as scheme-less when they are localhost, IPv4/IPv6, or contain a dot, so inputs like myservice:8080/path now get parsed as scheme myservice and fail with Unsupported URL scheme instead of being normalized to https://.... This is a regression from the previous behavior (which prefixed https:// for any non-HTTP(S) input) and breaks common intranet/local-DNS usage where hostnames are single-label.
Useful? React with 👍 / 👎.
1 participant
Summary
skills/smart-web-fetch/main.pybootstrapcore.pyshadowing regressions and update docs/specs to reflect the new internal contractTesting
spec/tests/offline-regression.shspec/tests/json-smoke.shspec/tests/json-smoke.ps1