Skip to content

GEOPY-2972: define version, icon, and documentation to the plate sweep option class #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benk-mira merged 2 commits into from
Oct 1, 2026
Merged

GEOPY-2972: define version, icon, and documentation to the plate sweep option class #223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13fd726
Add defaults to Options for version, icon and docs
domfournier Oct 1, 2026
0ac65ba
Update unit test
domfournier Oct 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions geoapps_utils/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -244,6 +244,12 @@ class Options(BaseModel):
geoh5: Workspace
monitoring_directory: str | Path | None = None
out_group: UIJsonGroup | None = None
version: str | None = "0.0.0"
icon: str | None = ""
documentation: str | None = (
"https://mirageoscience-geoh5py.readthedocs-hosted.com/en/latest/"
+ "content/uijson_format/index.html"
)
Comment thread
domfournier marked this conversation as resolved.

_ui_json_class: ClassVar[type[UIJson]] = UIJson

Expand Down
6 changes: 3 additions & 3 deletions tests/dataclass_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,10 +62,10 @@ def test_dataclass_valid_values(tmp_path):
valid_parameters = get_params_dict(tmp_path / f"{__name__}.geoh5")
model = Options(**valid_parameters)
output_params = model.model_dump()
assert len(output_params) == len(valid_parameters)
assert len(output_params) == len(valid_parameters) + 3

for k, v in output_params.items():
assert valid_parameters[k] == v
for k, v in valid_parameters.items():
assert output_params[k] == v


def test_dataclass_invalid_values(tmp_path):
Expand Down
Loading