Repository navigation
Conversation
github-actions
Bot
changed the title
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1000 +/- ##
========================================
Coverage 91.02% 91.03%
========================================
Files 130 130
Lines 11326 11347 +21
Branches 2091 2092 +1
========================================
+ Hits 10310 10330 +20
- Misses 531 532 +1
Partials 485 485
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
🟡 Changes recommended
Automatic cleanup can delete the only complete workspace copy when cross-filesystem replacement fails.
1 open issue
What changed in this PR
Addresses workspace repacking collisions by isolating temporary output for each close operation.
Changes:
- Uses a unique temporary directory with automatic cleanup.
- Adds regression coverage for same-named workspaces and temporary-file cleanup.
- Updates development dependency locks.
| File | Description |
|---|---|
tests/workspace_test.py |
Tests unique repack paths and cleanup. |
poetry.lock |
Refreshes development dependencies. |
geoh5py/workspace/workspace.py |
Isolates temporary repack output per operation. |
Review effort: Balanced
while keeping pytlint at 4.0 (pylint 4.1 is raising new findings)
|
|
…PY-3110 and rerun poetry update # Conflicts: # poetry.lock
for more information, see https://pre-commit.ci
|
@copilot, apply fix for |
| Set the attribute value. | ||
| """ | ||
| if key in TextEntry.model_fields: # pylint: disable=unsupported-membership-test | ||
| if key in TextEntry.model_fields.keys(): |
There was a problem hiding this comment.
I thought about that too but writing TextEntry.model_fields.plop(): make pylint happy as well, and not other checks report that plop does no exist :(
so I thought the disable was better than calling a function just for the sake of confusing pylint enough for it not to report
There was a problem hiding this comment.
It's more about a recent'ish change from pydantic
|
|
||
| def nan2str(value): | ||
| if value is np.nan: | ||
| if value is np.nan: # pylint: disable=nan-comparison |
There was a problem hiding this comment.
suggestion: math.isnan(value) instead of disabling pylint
|
|
temp dir could be on another file system, causing costly copy
|
|
| try: | ||
| if math.isnan(value): | ||
| return "" | ||
| except TypeError: |
GEOPY-3110 - File collision upon close and repacking of geoh5 workspaces