Repository navigation
GEOPY-3101: Update toml to latest format - #21
Merged
Merged
Conversation
RomFloreani
commented
Oct 22, 2026
github-actions
Bot
changed the title
RomFloreani
marked this pull request as ready for review
October 27, 2026 13:24
There was a problem hiding this comment.
🟡 Changes recommended
Static analysis requires a missing Poetry lockfile, and the WIP and Jira workflows lack the permissions or secrets needed for fork PRs.
3 open issues
What changed in this PR
Modernizes the training project's Poetry configuration and Conda environments, and adds shared GitHub automation for code checks and dependency maintenance.
Changes:
- Switches Poetry to non-package mode, reorganizes development dependencies, and expands Ruff configuration.
- Refreshes Linux and Windows Conda locks, adding Notebook and separating development tools.
- Adds static analysis, security scanning, PR metadata workflows, and Dependabot automation.
| File | Description |
|---|---|
pyproject.toml |
Modernizes metadata, dependency groups, and lint settings. |
environments/py-3.12-win-64.conda.lock.yml |
Refreshes Windows runtime dependencies. |
environments/py-3.12-win-64-dev.conda.lock.yml |
Refreshes Windows development dependencies. |
environments/py-3.12-linux-64.conda.lock.yml |
Refreshes Linux runtime dependencies. |
environments/py-3.12-linux-64-dev.conda.lock.yml |
Refreshes Linux development dependencies. |
.github/workflows/wip-status.yml |
Adds PR title-based WIP status reporting. |
.github/workflows/static_analysis.yml |
Adds shared pre-commit checks. |
.github/workflows/security_scan.yml |
Adds shared workflow security scanning. |
.github/workflows/pr_jira_actions.yml |
Adds Jira validation and PR updates. |
.github/workflows/dependabot-auto-merge.yml |
Adds auto-merge for selected dependency groups. |
.github/dependabot.yml |
Schedules grouped Actions and pre-commit updates. |
Review effort: Balanced
sebhmg
reviewed
Oct 27, 2026
sebhmg
requested changes
Oct 27, 2026
sebhmg
left a comment
sebhmg
left a comment
Contributor
There was a problem hiding this comment.
need to refresh a few scripts and mechanisms to align on how things are done in our other packages with a conda env. See for example geoapps-utils
also, no need for the activated env in terminal in case of failure, as confuses most users not to be in a activated conda env
faster at resolving dependencies
sebhmg
approved these changes
Oct 28, 2026
Contributor
|
I have tested installation and startup of the notebook |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-3101 - Update toml to latest format
Files with meaningful changes
Dependencies / environment
pyproject.toml: first iteration of the[project]/ Poetry 2 configurationpy-3.12.conda-lock.yml: re-lockedenvironments/py-3.12-linux-64.conda.lock.ymlenvironments/py-3.12-linux-64-dev.conda.lock.ymlenvironments/py-3.12-win-64.conda.lock.ymlenvironments/py-3.12-win-64-dev.conda.lock.ymlCI (pinned to CI-tools v3.13.6)
.github/workflows/pr_jira_actions.yml: JIRA required checks.github/workflows/security_scan.yml: Zizmor required check.github/workflows/wip-status.yml.github/workflows/dependabot-auto-merge.yml.github/dependabot.yml: targetsmainConfig
.codespellignore: addedastroid(package name in the lock files, flagged as a typo)Formatting only (pre-commit auto-fixes, no logic changes)
assets/training/*.ipynbandcontent/fundamentals/{1-collections,5-geoh5_api,7-mag_dipole_app}.ipynb(cell key ordering, trailing newlines)content/conf.py,devtools/{add_url_tag_sha256,check-copyright,run_conda_lock,update_tutorials}.py,tests/notebook_test.py(import sorting, blank lines, ruff format)setup_no_conda.bat,start_training.bat(trailing whitespace)