GEOPY-3048: Crash on start_dask_run for 1D inversions

[domfournier]

GEOPY-3048 - Crash on start_dask_run for 1D inversions

[Copilot]

Copilot review overview

🟡 Changes recommended

Unresolved critical and moderate findings remain in the 1D driver, and the regression test does not cover the changed entry point.

Get a fresh assessment by requesting another Copilot review.

Review effort: Lite
Findings: 1 · 1 · 1

Open (3)

• Override signature breaks positional n_workers and n_threads callers · New
• None-valued CLI options prevent parallelization defaults · New
• Regression test bypasses the changed start_dask_run path · New

What changed in this PR

GEOPY-3048 updates 1D electromagnetic drivers for Dask startup, restart handling, and DrapeModel/Octree mesh support.

Changes:

• Adds DrapeModel/Octree-aware mesh construction.
• Updates Dask argument handling and UI defaults.
• Expands airborne TEM 1D restart test coverage.

File	Summary	Final review notes
tests/​run_tests/​driver_airborne_tem_1d_test.py	Updates synthetic inversion and restart tests.	Nit: does not exercise the changed start_dask_run entry point (2 votes).
simpeg_drivers/​electromagnetics/​base_1d_driver.py	Updates mesh handling and Dask startup.	Critical signature compatibility issue (2 votes); moderate default normalization issue (2 votes); moderate negative cell-size issue (1 vote).
simpeg_drivers-assets/​uijson/​tdem1d_inversion.ui.json	Updates TDEM inversion defaults and mesh types.	No final comments.
simpeg_drivers-assets/​uijson/​tdem1d_forward.ui.json	Updates TDEM forward defaults and mesh types.	No final comments.
simpeg_drivers-assets/​uijson/​fdem1d_inversion.ui.json	Updates FDEM inversion defaults and mesh types.	No final comments.
simpeg_drivers-assets/​uijson/​fdem1d_forward.ui.json	Updates FDEM forward defaults and mesh types.	No final comments.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[codecov]

Codecov Report

❌ Patch coverage is 53.84615% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.45%. Comparing base (b5605a2) to head (dfcd557).

Files with missing lines	Patch %	Lines
simpeg_drivers/electromagnetics/base_1d_driver.py	53.84%	5 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop     #480      +/-   ##
===========================================
- Coverage    90.51%   90.45%   -0.06%     
===========================================
  Files          111      111              
  Lines         7095     7105      +10     
  Branches       876      880       +4     
===========================================
+ Hits          6422     6427       +5     
- Misses         454      458       +4     
- Partials       219      220       +1     

Files with missing lines	Coverage Δ
simpeg_drivers/electromagnetics/base_1d_driver.py	88.31% <53.84%> (-5.72%)	⬇️

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.