Skip to content

GEOPY-2630: Tile estimation creates a new group, but should use the one you give it. - #481

Merged
domfournier merged 4 commits into
developfrom
GEOPY-2630
Sep 28, 2026
Merged

domfournier merged 4 commits into
developfrom
GEOPY-2630

Conversation

@domfournier

@domfournier domfournier commented Sep 22, 2026 •

Copy link
Copy Markdown
Collaborator

GEOPY-2630 - Tile estimation creates a new group, but should use the one you give it.

Copilot AI lite review requested due to automatic review settings September 22, 2026 20:14
@github-actions github-actions Bot changed the title GEOPY-2630 GEOPY-2630: Tile estimation creates a new group, but should use the one you give it. Sep 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Restore coverage for default output behavior and update the return annotation for UIJsonGroup.

Review effort: Lite
Findings: None

What changed in this PR

Adds optional output-group support to tile estimation while simplifying initialization and updating integration coverage.

Changes:

  • Exposes an optional output-group selector.
  • Makes tile parameters mutable and avoids eager inversion setup.
  • Updates grouped-output tests.
File Summary
tests/​run_tests/​driver_tile_estimator_test.py Tests explicit output-group handling.
simpeg_drivers/​utils/​tile_estimate.py Supports mutable parameters and grouped output.
simpeg_drivers-assets/​uijson/​tile_estimator.ui.json Adds the optional output-group field.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Base automatically changed from GEOPY-196 to develop September 24, 2026 15:23
@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.48%. Comparing base (24b4b9e) to head (25faafb).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #481      +/-   ##
===========================================
+ Coverage    90.45%   90.48%   +0.02%     
===========================================
  Files          111      111              
  Lines         7105     7105              
  Branches       880      880              
===========================================
+ Hits          6427     6429       +2     
+ Misses         458      456       -2     
  Partials       220      220              
Files with missing lines Coverage Δ
simpeg_drivers/utils/tile_estimate.py 88.97% <100.00%> (+1.47%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@domfournier
domfournier merged commit f3d1d01 into develop Sep 28, 2026
20 of 21 checks passed
@domfournier
domfournier deleted the GEOPY-2630 branch September 28, 2026 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants