Repository navigation
GEOPY-2630: Tile estimation creates a new group, but should use the one you give it. - #481
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🔵 Needs a closer look
Restore coverage for default output behavior and update the return annotation for UIJsonGroup.
Review effort: Lite
Findings: None
What changed in this PR
Adds optional output-group support to tile estimation while simplifying initialization and updating integration coverage.
Changes:
- Exposes an optional output-group selector.
- Makes tile parameters mutable and avoids eager inversion setup.
- Updates grouped-output tests.
| File | Summary |
|---|---|
tests/run_tests/driver_tile_estimator_test.py |
Tests explicit output-group handling. |
simpeg_drivers/utils/tile_estimate.py |
Supports mutable parameters and grouped output. |
simpeg_drivers-assets/uijson/tile_estimator.ui.json |
Adds the optional output-group field. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
benk-mira
approved these changes
Sep 28, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #481 +/- ##
===========================================
+ Coverage 90.45% 90.48% +0.02%
===========================================
Files 111 111
Lines 7105 7105
Branches 880 880
===========================================
+ Hits 6427 6429 +2
+ Misses 458 456 -2
Partials 220 220
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-2630 - Tile estimation creates a new group, but should use the one you give it.