Repository navigation
GEOPY-665: Add reference model in gradient term (smooth_mod_diff) options - #483
Merged
Merged
Conversation
github-actions
Bot
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Specialized MVI-PDE and cross-gradient propagation lacks coverage, and the new user-facing tooltips contain a repeated grammatical error.
Review effort: Balanced
Findings: 2
Open (21)
And 1 more that still need to be addressed.
What changed in this PR
Adds configurable reference-model subtraction to regularization smoothness terms across standard and joint inversions.
Changes:
- Propagates
reference_model_in_smooththrough inversion options and regularization builders. - Exposes the option in inversion UI definitions.
- Adds coverage for gravity, joint-survey, and PGI workflows and updates PGI targets.
| File | Description |
|---|---|
tests/run_tests/driver_joint_surveys_test.py |
Tests joint-survey propagation. |
tests/run_tests/driver_joint_pgi_homogeneous_test.py |
Tests PGI propagation and updates targets. |
tests/run_tests/driver_grav_test.py |
Tests standard regularization propagation. |
simpeg_drivers/potential_fields/magnetic_vector_pde/inversion.py |
Configures vector-amplitude regularization. |
simpeg_drivers/options.py |
Adds the base inversion option. |
simpeg_drivers/joint/options.py |
Adds the joint inversion option. |
simpeg_drivers/joint/joint_surveys/driver.py |
Propagates the joint-survey setting. |
simpeg_drivers/joint/joint_cross_gradient/driver.py |
Propagates explicit cross-gradient settings. |
simpeg_drivers/joint/driver.py |
Applies settings to component regularizations. |
simpeg_drivers/driver.py |
Passes the option to sparse regularization. |
simpeg_drivers-assets/uijson/tipper_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/tdem1d_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/tdem_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/magnetotellurics_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/magnetic_vector_pde_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/magnetic_vector_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/magnetic_scalar_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/joint_surveys_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/joint_petrophysics_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/joint_cross_gradient_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/induced_polarization_3d_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/induced_polarization_2d_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/gravity_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/fdem1d_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/fdem_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/direct_current_3d_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/direct_current_2d_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/borehole_tdem_inversion.ui.json |
Adds the UI control. |
simpeg_drivers-assets/uijson/apparent_conductivity_inversion.ui.json |
Adds the UI control. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #483 +/- ##
===========================================
- Coverage 90.48% 90.47% -0.02%
===========================================
Files 111 111
Lines 7108 7126 +18
Branches 881 884 +3
===========================================
+ Hits 6432 6447 +15
- Misses 456 457 +1
- Partials 220 222 +2
🚀 New features to boost your workflow:
|
benk-mira
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GEOPY-665 - Add reference model in gradient term (smooth_mod_diff) options