Repository navigation
GEOPY-2972: define version, icon, and documentation to the plate sweep option class - #485
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The change allows UI metadata into trial hashes and options because the locked base model lacks those fields.
Review effort: Balanced
Findings: 1
What changed in this PR
Updates metadata filtering for plate-sweep trial options.
Changes:
- Simplifies the list of excluded UI option fields.
| File | Description |
|---|---|
simpeg_drivers/plate_simulation/sweep/options.py |
Updates metadata exclusion logic. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "icon", | ||
| "documentation", | ||
| ] | ||
| exceptions = list(Options.model_fields) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #485 +/- ##
===========================================
- Coverage 90.51% 90.48% -0.03%
===========================================
Files 111 111
Lines 7095 7105 +10
Branches 876 880 +4
===========================================
+ Hits 6422 6429 +7
- Misses 454 456 +2
- Partials 219 220 +1
🚀 New features to boost your workflow:
|
benk-mira
approved these changes
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

GEOPY-2972 - define version, icon, and documentation to the plate sweep option class