Skip to content

GEOPY-2972: define version, icon, and documentation to the plate sweep option class - #485

Merged
domfournier merged 1 commit into
developfrom
GEOPY-2972
Oct 5, 2026
Merged

domfournier merged 1 commit into
developfrom
GEOPY-2972

Conversation

@domfournier

@domfournier domfournier commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

GEOPY-2972 - define version, icon, and documentation to the plate sweep option class

Copilot AI balanced review requested due to automatic review settings October 1, 2026 13:54
@github-actions github-actions Bot changed the title GEOPY-2972 GEOPY-2972: define version, icon, and documentation to the plate sweep option class Oct 1, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The change allows UI metadata into trial hashes and options because the locked base model lacks those fields.

Review effort: Balanced
Findings: 1 Medium severity

Open (1)
What changed in this PR

Updates metadata filtering for plate-sweep trial options.

Changes:

  • Simplifies the list of excluded UI option fields.
File Description
simpeg_drivers/​plate_simulation/​sweep/​options.py Updates metadata exclusion logic.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

"icon",
"documentation",
]
exceptions = list(Options.model_fields)
@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.48%. Comparing base (b5605a2) to head (6eb199f).
⚠️ Report is 15 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #485      +/-   ##
===========================================
- Coverage    90.51%   90.48%   -0.03%     
===========================================
  Files          111      111              
  Lines         7095     7105      +10     
  Branches       876      880       +4     
===========================================
+ Hits          6422     6429       +7     
- Misses         454      456       +2     
- Partials       219      220       +1     
Files with missing lines Coverage Δ
simpeg_drivers/plate_simulation/sweep/options.py 92.78% <100.00%> (ø)

... and 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@domfournier
domfournier merged commit f264a74 into develop Oct 5, 2026
22 checks passed
@domfournier
domfournier deleted the GEOPY-2972 branch October 5, 2026 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants