Repository navigation
GEOPY-1889: Return nan on predicted where data is nan - #493
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Scalar DC/IP normalizations cause the new masking assignment to raise a TypeError.
1 open finding
What changed in this PR
Ensures saved predicted data preserves NaN positions from observed data.
Changes:
- Masks prediction transforms using observed-data NaNs.
- Adds gravity and magnetotelluric regression coverage.
- Updates magnetotelluric workspace names and expected metrics.
| File | Description |
|---|---|
directives_factory.py |
Adds NaN masking to saved data transforms. |
driver_grav_test.py |
Expects one NaN in predicted gravity data. |
driver_mt_test.py |
Tests NaN propagation and updates workspace paths. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
benk-mira
previously approved these changes
Oct 14, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #493 +/- ##
========================================
Coverage 90.51% 90.51%
========================================
Files 111 111
Lines 7134 7137 +3
Branches 886 887 +1
========================================
+ Hits 6457 6460 +3
Misses 456 456
Partials 221 221
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

GEOPY-1889 - Return nan on predicted where data is nan