Skip to content

GEOPY-1889: Return nan on predicted where data is nan - #493

Merged
domfournier merged 4 commits into
developfrom
GEOPY-1889
Oct 15, 2026
Merged

domfournier merged 4 commits into
developfrom
GEOPY-1889

Conversation

@domfournier

@domfournier domfournier commented Oct 13, 2026 •

Copy link
Copy Markdown
Collaborator

GEOPY-1889 - Return nan on predicted where data is nan

Copilot AI balanced review requested due to automatic review settings October 13, 2026 21:38
@github-actions github-actions Bot changed the title GEOPY-1889 GEOPY-1889: Return nan on predicted where data is nan Oct 13, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Scalar DC/IP normalizations cause the new masking assignment to raise a TypeError.

1 open finding
What changed in this PR

Ensures saved predicted data preserves NaN positions from observed data.

Changes:

  • Masks prediction transforms using observed-data NaNs.
  • Adds gravity and magnetotelluric regression coverage.
  • Updates magnetotelluric workspace names and expected metrics.
File Description
directives_factory.py Adds NaN masking to saved data transforms.
driver_grav_test.py Expects one NaN in predicted gravity data.
driver_mt_test.py Tests NaN propagation and updates workspace paths.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread simpeg_drivers/components/factories/directives_factory.py
Base automatically changed from GEOPY-3100 to develop October 13, 2026 22:22
benk-mira
benk-mira previously approved these changes Oct 14, 2026
@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.51%. Comparing base (f6929c3) to head (0966590).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #493   +/-   ##
========================================
  Coverage    90.51%   90.51%           
========================================
  Files          111      111           
  Lines         7134     7137    +3     
  Branches       886      887    +1     
========================================
+ Hits          6457     6460    +3     
  Misses         456      456           
  Partials       221      221           
Files with missing lines Coverage Δ
simpeg_drivers/components/data.py 95.91% <ø> (-0.09%) ⬇️
...drivers/components/factories/directives_factory.py 95.88% <100.00%> (+0.11%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@domfournier
domfournier merged commit 44a3857 into develop Oct 15, 2026
20 of 21 checks passed
@domfournier
domfournier deleted the GEOPY-1889 branch October 15, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants