Repository navigation
GEOPY-3102: Unwanted augmentation of active cells for airborne receivers and large loop source - #494
Open
domfournier wants to merge 4 commits into
Open
domfournier wants to merge 4 commits into
domfournier wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
A targeted regression test is needed because existing assertions do not distinguish the corrected cell selection from the previous behaviour.
1 open finding
What changed in this PR
This PR addresses GEOPY-3102 by preventing large-loop receivers from unnecessarily expanding the inversion’s active cells.
Changes:
- Restricts large-loop TreeMesh cell selection to transmitter paths.
- Updates ground TEM inversion reference targets.
| File | Description |
|---|---|
| tests/run_tests/driver_ground_tem_test.py | Adjusts expected inversion metrics. |
| simpeg_drivers/utils/utils.py | Excludes receiver locations from large-loop cell selection. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| ) | ||
| ) | ||
| inds = np.r_[inds, np.hstack(line_ind)] | ||
| inds = np.hstack(line_ind) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #494 +/- ##
========================================
Coverage 90.51% 90.51%
========================================
Files 111 111
Lines 7134 7134
Branches 886 886
========================================
Hits 6457 6457
Misses 456 456
Partials 221 221
🚀 New features to boost your workflow:
|
benk-mira
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

GEOPY-3102 - Unwanted augmentation of active cells for airborne receivers and large loop source