Skip to content

GEOPY-3102: Unwanted augmentation of active cells for airborne receivers and large loop source - #494

Open
domfournier wants to merge 4 commits into
developfrom
GEOPY-3102
Open

domfournier wants to merge 4 commits into
developfrom
GEOPY-3102

Conversation

@domfournier

@domfournier domfournier commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

GEOPY-3102 - Unwanted augmentation of active cells for airborne receivers and large loop source

Copilot AI balanced review requested due to automatic review settings October 14, 2026 23:49
@github-actions github-actions Bot changed the title GEOPY-3102 GEOPY-3102: Unwanted augmentation of active cells for airborne receivers and large loop source Oct 14, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

A targeted regression test is needed because existing assertions do not distinguish the corrected cell selection from the previous behaviour.

1 open finding
What changed in this PR

This PR addresses GEOPY-3102 by preventing large-loop receivers from unnecessarily expanding the inversion’s active cells.

Changes:

  • Restricts large-loop TreeMesh cell selection to transmitter paths.
  • Updates ground TEM inversion reference targets.
File Description
tests/​run_tests/​driver_ground_tem_test.py Adjusts expected inversion metrics.
simpeg_drivers/​utils/​utils.py Excludes receiver locations from large-loop cell selection.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

)
)
inds = np.r_[inds, np.hstack(line_ind)]
inds = np.hstack(line_ind)
@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.51%. Comparing base (f6929c3) to head (78c2092).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #494   +/-   ##
========================================
  Coverage    90.51%   90.51%           
========================================
  Files          111      111           
  Lines         7134     7134           
  Branches       886      886           
========================================
  Hits          6457     6457           
  Misses         456      456           
  Partials       221      221           
Files with missing lines Coverage Δ
simpeg_drivers/utils/utils.py 61.56% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants