Repository navigation
chore: remove README demo generator and its gifski dependency - #70
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The README demo generator (
tools/demo/make-demo.mjs) was the only reason contributors needed gifski on their PATH. We don't regenerate the demo anymore, so the script goes away; the existingdocs/assets/demo.gifstays and is still shown in the README and docs.tools/demo/make-demo.mjsCONTRIBUTING.md@resvg/resvg-wasmstays, the CLI renders with itChecklist
npm run typecheckpassesnpm run gatepassessrc/guide.tsand the matching page indocs/are updated (only if a command, option or output changed)Linked issue
None