refactor: simplify GTFS entity container parameterization - #2180
Open
mackenziereading19 wants to merge 1 commit into
Open
refactor: simplify GTFS entity container parameterization#2180mackenziereading19 wants to merge 1 commit into
mackenziereading19 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Simplifies
GtfsEntityContainerby removing the unnecessary descriptor type parameter.GtfsEntityContainer<T, D>stored the descriptor asD, but callers only rely on the baseGtfsFileDescriptorAPI. This change reduces it toGtfsEntityContainer<T>while preserving the descriptor-specific generic onGtfsTableContainer<T, D>, where it is still useful.Fixes #1865.
Changes
D extends GtfsFileDescriptorfromGtfsEntityContainer;GtfsFileDescriptor;GtfsTableContainer<T, D>and its table-descriptor typing.Validation
:core:compileJava— pass:main:compileJava— pass:core:test— passFeedMetadataTest— passTranslationFieldAndReferenceValidatorTest— pass:core:spotlessCheck :main:spotlessCheck— passgit diff --check— passGtfsEntityContainer<..., ...>referencesFull
:main:testcompleted 678 tests with 3 failures. The failures are the existing Mockito initialization failures in:JsonReportSummaryGeneratorTest.withFeedMetadataWithConfigTestJsonReportSummaryGeneratorTest.withFeedMetadataNoConfigTestVersionResolverTestThese failures reproduce on the untouched baseline and are unrelated to this refactor.