feat: report empty required and recommended files - #2181
Open
mackenziereading19 wants to merge 1 commit into
Open
feat: report empty required and recommended files#2181mackenziereading19 wants to merge 1 commit into
mackenziereading19 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses #1853 by distinguishing GTFS files that are present with valid headers but contain no data rows.
The loader already treats a completely empty/headerless CSV as
EmptyFileNotice. However, a headers-only file is considered parsable and previously produced no notice even when the file was required or recommended.This change adds:
RequiredFileEmptyNotice(ERROR) for required files with headers but no data rows;RecommendedFileEmptyNotice(WARNING) for recommended files with headers but no data rows;EmptyFileNoticedocumentation so it only describes genuinely headerless files.The parsed table remains
PARSABLE_HEADERS_AND_ROWSin all headers-only cases because the file structure and headers are valid; the new notices describe the file-content requirement rather than reclassifying the table as missing or unparsable.Tests
Added regression coverage for:
RequiredFileEmptyNotice;RecommendedFileEmptyNotice;Local verification:
:core:test: pass;NoticeReferenceTest: pass;:core:spotlessCheckand:main:spotlessCheck: pass;git diff --check: pass.Fixes #1853