feat: validate consecutive stop times with same time - #2185
Open
mackenziereading19 wants to merge 1 commit into
Open
feat: validate consecutive stop times with same time#2185mackenziereading19 wants to merge 1 commit into
mackenziereading19 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements #178 by porting the historical Google Python validator check for trips with too many consecutive
stop_times.txtrows sharing the same fully specified time.The validator:
trip_idusing the existing grouped stop-time table architecture;INFOnotice when a run contains more than five consecutive stop-time records with the same arrival/departure time;tripId,entityCount, andtime.Tests
Added focused regression coverage for:
Focused result: 7 passed.
Full
:main:testresult locally: 682 passed, 3 failed. The three failures are pre-existing Java 21 / Mockito environment failures (JsonReportSummaryGeneratorTestx2 andVersionResolverTest) and were reproduced independently on untouched baseline21b27a4ac903bc2bc43d42a89bb3dbb47cc8921d.Closes #178