Skip to content

fix: add qwen3_omni_moe tool call parser mapping#1397

Merged
shihaobai merged 3 commits into
mainfrom
fix
Jul 17, 2026
Merged

fix: add qwen3_omni_moe tool call parser mapping#1397
shihaobai merged 3 commits into
mainfrom
fix

Conversation

@WANDY666

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request fixes a syntax error in the README.md BibTeX citation and adds support for the 'qwen3_omni_moe' model type in the tool call parser configuration. The reviewer suggests also adding 'qwen3_omni_moe' to the reasoning parser configuration for consistency and proper auto-detection.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread lightllm/utils/config_utils.py Outdated

# Qwen3 series
if model_type in ["qwen3", "qwen3_moe", "qwen3_vl", "qwen3_vl_moe", "qwen3_vl_text", "qwen3_vl_moe_text"]:
if model_type in ["qwen3", "qwen3_moe", "qwen3_omni_moe", "qwen3_vl", "qwen3_vl_moe", "qwen3_vl_text", "qwen3_vl_moe_text"]:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Since 'qwen3_omni_moe' is added to the Qwen3 series for the tool call parser, it should also be added to the Qwen3 series list in 'get_reasoning_parser_for_model' (around line 515) to ensure that the reasoning parser is correctly auto-detected for this model type.

@shihaobai
shihaobai merged commit 599971c into main Jul 17, 2026
1 check passed
@shihaobai
shihaobai deleted the fix branch July 17, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants