rfc: add RFC 0040, the system column namespace - #546
Merged
azimafroozeh merged 4 commits intoSep 1, 2026
Conversation
azimafroozeh
marked this pull request as ready for review
August 23, 2026 15:50
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Aug 24, 2026
This was referenced Aug 31, 2026
Contributor
|
The design is sound — spelling resolution keyed on the accepted IR's vintage (never physical inspection) keeps one source of truth, the meta-fields are proper grammar constructs, and the no-migration story is credible including the resolver-stamping landmine you caught. The reserved Three fixes before acceptance:
|
azimafroozeh
force-pushed
the
rfc-system-column-namespace
branch
from
September 1, 2026 13:51
cf354b6 to
463fd70
Compare
azimafroozeh
force-pushed
the
rfc-system-column-namespace
branch
from
September 1, 2026 13:53
463fd70 to
cd7aef7
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
This PR adds RFC 0040, which frees the property names
id,src, anddstfor user schemas and moves OmniGraph's implicit stored columns into a reserved namespace. Motivated by #529: a ported schema whose natural key is namedidcollides with the implicit physical id column, failing with a misleading error when declared with@keyand silently producing a duplicate physical column without it.__id/__src/__dst; every existing graph keeps its current spellings through per-graph resolution keyed on its schema IR version, so the design contains no migration.$p.@id,$e.@src,$e.@dst) that work on every graph;$p.idkeeps its exact current behavior on existing graphs (with a deprecation lint) and refers only to a user property on new ones.Backing issue / RFC
docs/rfcs/0040-system-column-namespace.md); motivated by bug: a node property namedidsilently collides with the implicit physical id column, and @key then fails claiming the property is undeclared #529. A companion bug-fix patch reserving the three names lands separately before the implementation: it is the fence that makes the RFC's coexistence guarantees provable.Checklist
Local verification
docs/rfcs/, outside the guarded surfacesNotes for reviewers
Greptile Summary
The PR adds RFC 0040, proposing a reserved system-column namespace while preserving existing graph spellings through per-graph schema vintage.
__id,__src, and__dststorage names and corresponding query meta-fields.Confidence Score: 5/5
The PR appears safe to merge because no blocking failure remains from the previously reported issues.
The revised RFC preserves vintage during ordinary applies, moves stored-query rewriting outside the graph transaction with a post-upgrade validation gate, and documents an ordered restart-before-upgrade rollout.
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR Old[Old-vintage graph<br/>id / src / dst] --> Apply[Ordinary schema apply] Apply --> Old Old --> Rewrite[Rewrite stored queries<br/>to meta-fields] Rewrite --> Restart[Restart with rewritten registry] Restart --> Upgrade[Explicit graph upgrade] Upgrade --> New[New-vintage graph<br/>__id / __src / __dst] New --> Meta[Queries use @id / @src / @dst]Reviews (4): Last reviewed commit: "review" | Re-trigger Greptile