ci: emit Windows checksum manifests with LF - #594
Open
roy2392 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #588
Summary
Windows release checksum files were written with PowerShell
Out-File, which emits CRLF. Unixshasum -c/sha256sum -cthen treats the filename as ending in\rand fails.This writes the
.sha256manifest with explicit LF (no BOM), rejects a CR on the Windows builder, and adds a Unix-sidesha256sum --strict -cgate before the GitHub release is published. The same write path is fixed in the edge workflow.v0.10.0 assets are left alone; this applies to subsequent releases only.
Test plan
omnigraph-windows-x86_64.sha256without CRsha256sum --strict -con ubuntu accepts the Windows manifest (and the Unix ones)Greptile Summary
The PR fixes Windows checksum manifests to use LF without a BOM and adds a release-time portability and checksum-integrity gate before publication.
sha256sum --strict.Confidence Score: 5/5
The PR appears safe to merge with no actionable correctness, security, or workflow issues identified.
The Windows writer produces a GNU-compatible checksum line with an explicit LF and no BOM, while the stable release gate verifies colocated manifests and archives before publication.
Important Files Changed
Reviews (1): Last reviewed commit: "ci: emit Windows edge checksum manifests..." | Re-trigger Greptile