-
Notifications
You must be signed in to change notification settings - Fork 0
Settle camera + simulation presets: fix the first-load feel #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| --- | ||
| '@modernrelay/orbit-core': minor | ||
| '@modernrelay/orbit-react': minor | ||
| --- | ||
|
|
||
| First-load feel: the settle camera and simulation presets. | ||
|
|
||
| Two measured problems on every fresh force-layout mount: the first-data fit | ||
| frames the seed ring while the simulation contracts the graph to 5–17% of | ||
| that frame (a distant blob), and the engine's default cooling keeps visible | ||
| motion alive for tens of seconds (reads as endless jitter). | ||
|
|
||
| - **Settle camera** — new `fitViewOnSettle` option (`'follow'` (default) | | ||
| `'once'` | `false`). Under `'follow'` the camera keeps the settling graph | ||
| framed with periodic animated refits riding the engine frame fan-out (no | ||
| timers, no extra rAF) and a final fit at first quiescence; any user camera | ||
| input cancels it. `'once'` fits a single time at quiescence; `false` | ||
| restores the previous behavior. | ||
| - **Simulation presets** — `simulation` now also accepts a preset name: | ||
| `'calm'`, `'spread'`, `'tight'`, or `'lively'` (`SIMULATION_PRESETS` and | ||
| `resolveSimulation` are exported). Presets were selected on a measured | ||
| protocol: seconds until sustained visible stillness on an 800-node | ||
| clustered graph. | ||
| - **Default changed**: an omitted `simulation` now resolves to the `'calm'` | ||
| preset (visually still in ~5s) instead of the engine's own defaults. The | ||
| old feel is one prop away: `simulation="lively"`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.