Version packages: 0.16.0 - #8
Merged
Merged
Conversation
| // Usage: node run-sweep.mjs <outDir> | ||
| import { chromium } from '@playwright/test'; | ||
|
|
||
| const OUT = process.argv[2] ?? 'sweep-out'; |
There was a problem hiding this comment.
When a developer uses a new output directory or the default sweep-out, the runner writes its first screenshot before creating that directory, causing the sweep to abort before producing measurements or its summary.
Suggested change
| const OUT = process.argv[2] ?? 'sweep-out'; | |
| const OUT = process.argv[2] ?? 'sweep-out'; | |
| await (await import('node:fs/promises')).mkdir(OUT, { recursive: true }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release train for 0.16.0 (lockstep minor across the five packages): the settle camera + simulation presets and the fit zoom clamp — the first-load-feel pair. Changesets consumed; publish mode fires on merge.
🤖 Generated with Claude Code
https://claude.ai/code/session_018SeFxK217ZrHSERqK6kjcb
Greptile Summary
This release-train PR consumes two changesets and advances all five Orbit packages to 0.16.0 while adding changelog entries for the fit-zoom clamp, settle-camera behavior, and simulation presets.
Confidence Score: 4/5
The package release metadata appears safe, but the new sweep runner should create its output directory before it is used.
The lockstep version changes and workspace dependency metadata are consistent; the concrete defect is isolated to the auxiliary sweep runner, whose documented default invocation aborts at its first screenshot when the destination directory is absent.
Files Needing Attention: apps/demo/run-sweep.mjs
Important Files Changed
Reviews (1): Last reviewed commit: "Version packages: 0.16.0 lockstep" | Re-trigger Greptile